Restore visual benchmark links in README tables - #136
Merged
Merged
Conversation
Restore a visual-results column to the implementation tables in the English and translated READMEs. Track the six self-contained comparison reports and images so every link resolves on GitHub.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (72)
📒 Files selected for processing (19)
📝 WalkthroughWalkthroughThe change adds generated benchmark reports for .NET, Rust, Java, Python, Node.js, and Go. English and localized README tables now link to each implementation's visual comparison report. ChangesBenchmark report publication
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🟢 Approval recommended
The README/table updates are consistently applied across all listed translations and the linked benchmark report targets exist in-repo under the referenced paths.
Pull request overview
This PR restores a “Visual results” column in the main implementation table and syncs that table across the translated READMEs, with report artifacts checked in under artifacts/benchmark/<language>/report/ so the links resolve directly on GitHub.
Changes:
- Add a “Visual results” column with per-language report links in
README.md. - Mirror the updated implementation table (including report links) across the six translated READMEs.
- Add per-language benchmark report outputs (
comparison_report.md/.json) underartifacts/benchmark/for .NET, Rust, Java, Python, Node, and Go.
File summaries
| File | Description |
|---|---|
| README.md | Adds “Visual results” column linking to per-language benchmark reports. |
| documents/README.zh-TW.md | Syncs implementation table and adds visual report links (relative to documents/). |
| documents/README.zh-CN.md | Syncs implementation table and adds visual report links (relative to documents/). |
| documents/README.ko.md | Syncs implementation table and adds visual report links (relative to documents/). |
| documents/README.ja.md | Syncs implementation table and adds visual report links (relative to documents/). |
| documents/README.it.md | Syncs implementation table and adds visual report links (relative to documents/). |
| documents/README.fr.md | Syncs implementation table and adds visual report links (relative to documents/). |
| artifacts/benchmark/dotnet/report/comparison_report.md | Adds checked-in .NET visual/text comparison report (Markdown). |
| artifacts/benchmark/dotnet/report/comparison_report.json | Adds checked-in .NET visual/text comparison report data (JSON). |
| artifacts/benchmark/rust/report/comparison_report.md | Adds checked-in Rust visual/text comparison report (Markdown). |
| artifacts/benchmark/rust/report/comparison_report.json | Adds checked-in Rust visual/text comparison report data (JSON). |
| artifacts/benchmark/java/report/comparison_report.md | Adds checked-in Java visual/text comparison report (Markdown). |
| artifacts/benchmark/java/report/comparison_report.json | Adds checked-in Java visual/text comparison report data (JSON). |
| artifacts/benchmark/python/report/comparison_report.md | Adds checked-in Python visual/text comparison report (Markdown). |
| artifacts/benchmark/python/report/comparison_report.json | Adds checked-in Python visual/text comparison report data (JSON). |
| artifacts/benchmark/node/report/comparison_report.md | Adds checked-in Node visual/text comparison report (Markdown). |
| artifacts/benchmark/node/report/comparison_report.json | Adds checked-in Node visual/text comparison report data (JSON). |
| artifacts/benchmark/go/report/comparison_report.md | Adds checked-in Go visual/text comparison report (Markdown). |
| artifacts/benchmark/go/report/comparison_report.json | Adds checked-in Go visual/text comparison report data (JSON). |
Review details
- Files reviewed: 19/91 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
git diff --cached --checkSummary by CodeRabbit