Fix visual links to use canonical benchmark reports - #137
Merged
Merged
Conversation
Replace the temporary LibreOffice-only shared reports with the existing per-language issue XLSX reports that use Microsoft 365 as the primary reference. Update all localized README links and remove the mistakenly published artifact tree.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (148)
📒 Files selected for processing (35)
📝 WalkthroughWalkthroughThe change adds issue XLSX benchmark artifacts for four implementations, removes the previous dotnet report JSON, and updates English and translated README links to language-specific benchmark report paths. ChangesBenchmark report migration
Estimated code review effort: 3 (Moderate) | ~20 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🟡 Changes recommended
The README implementation matrices list Python inputs as “DOCX” even though the Python implementation supports XLSX and PPTX, making the updated tables inaccurate.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the implementation tables in the root README and all translated READMEs to link “Visual results” to the canonical per-language benchmark reports under artifacts/<language>-benchmark/issue/xlsx/report, and removes the previously published temporary LibreOffice-only report trees under artifacts/benchmark/<language>/report.
Changes:
- Updated all seven implementation tables to point visual links at canonical per-language issue/xlsx reports.
- Added/published canonical benchmark report artifacts for .NET, Python, Node, and Go under
artifacts/*-benchmark/issue/xlsx/report. - Removed the temporary LibreOffice-only report trees under
artifacts/benchmark/*/report.
File summaries
| File | Description |
|---|---|
| README.md | Updates visual report links to canonical per-language reports. |
| documents/README.zh-TW.md | Updates visual report links to canonical per-language reports. |
| documents/README.zh-CN.md | Updates visual report links to canonical per-language reports. |
| documents/README.ko.md | Updates visual report links to canonical per-language reports. |
| documents/README.ja.md | Updates visual report links to canonical per-language reports. |
| documents/README.it.md | Updates visual report links to canonical per-language reports. |
| documents/README.fr.md | Updates visual report links to canonical per-language reports. |
| artifacts/python-benchmark/issue/xlsx/report/comparison_report.md | Publishes canonical Python issue/xlsx benchmark report (Markdown). |
| artifacts/python-benchmark/issue/xlsx/report/comparison_manifest.json | Publishes canonical Python issue/xlsx benchmark manifest. |
| artifacts/python-benchmark/issue/xlsx/report/benchmark_coverage.json | Publishes canonical Python issue/xlsx benchmark coverage summary. |
| artifacts/node-benchmark/issue/xlsx/report/comparison_report.md | Publishes canonical Node issue/xlsx benchmark report (Markdown). |
| artifacts/node-benchmark/issue/xlsx/report/comparison_report.json | Publishes canonical Node issue/xlsx benchmark report (JSON). |
| artifacts/node-benchmark/issue/xlsx/report/comparison_manifest.json | Publishes canonical Node issue/xlsx benchmark manifest. |
| artifacts/node-benchmark/issue/xlsx/report/benchmark_coverage.json | Publishes canonical Node issue/xlsx benchmark coverage summary. |
| artifacts/go-benchmark/issue/xlsx/report/comparison_report.md | Publishes canonical Go issue/xlsx benchmark report (Markdown). |
| artifacts/go-benchmark/issue/xlsx/report/comparison_report.json | Publishes canonical Go issue/xlsx benchmark report (JSON). |
| artifacts/go-benchmark/issue/xlsx/report/comparison_manifest.json | Publishes canonical Go issue/xlsx benchmark manifest. |
| artifacts/go-benchmark/issue/xlsx/report/benchmark_coverage.json | Publishes canonical Go issue/xlsx benchmark coverage summary. |
| artifacts/dotnet-benchmark/issue/xlsx/report/comparison_report.md | Publishes canonical .NET issue/xlsx benchmark report (Markdown). |
| artifacts/dotnet-benchmark/issue/xlsx/report/comparison_report.json | Publishes canonical .NET issue/xlsx benchmark report (JSON). |
| artifacts/dotnet-benchmark/issue/xlsx/report/comparison_manifest.json | Publishes canonical .NET issue/xlsx benchmark manifest. |
| artifacts/dotnet-benchmark/issue/xlsx/report/benchmark_coverage.json | Publishes canonical .NET issue/xlsx benchmark coverage summary. |
| artifacts/benchmark/rust/report/comparison_report.md | Removes temporary LibreOffice-only benchmark report (Markdown). |
| artifacts/benchmark/rust/report/comparison_report.json | Removes temporary LibreOffice-only benchmark report (JSON). |
| artifacts/benchmark/python/report/comparison_report.md | Removes temporary LibreOffice-only benchmark report (Markdown). |
| artifacts/benchmark/python/report/comparison_report.json | Removes temporary LibreOffice-only benchmark report (JSON). |
| artifacts/benchmark/node/report/comparison_report.md | Removes temporary LibreOffice-only benchmark report (Markdown). |
| artifacts/benchmark/node/report/comparison_report.json | Removes temporary LibreOffice-only benchmark report (JSON). |
| artifacts/benchmark/java/report/comparison_report.md | Removes temporary LibreOffice-only benchmark report (Markdown). |
| artifacts/benchmark/java/report/comparison_report.json | Removes temporary LibreOffice-only benchmark report (JSON). |
| artifacts/benchmark/go/report/comparison_report.md | Removes temporary LibreOffice-only benchmark report (Markdown). |
| artifacts/benchmark/go/report/comparison_report.json | Removes temporary LibreOffice-only benchmark report (JSON). |
| artifacts/benchmark/dotnet/report/comparison_report.md | Removes temporary LibreOffice-only benchmark report (Markdown). |
| artifacts/benchmark/dotnet/report/comparison_report.json | Removes temporary LibreOffice-only benchmark report (JSON). |
Review details
- Files reviewed: 35/183 changed files
- Comments generated: 7
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| | .NET | XLSX, DOCX, PPTX | Library, CLI, Native AOT binaries | Stable | **[.NET guide](documents/README.nuget.md)** | **[Visual report](artifacts/dotnet-benchmark/issue/xlsx/report/comparison_report.md)** | | ||
| | Rust | XLSX, DOCX, PPTX | Crate, CLI | Experimental | **[Rust guide](minipdf-rs/README.md)** | **[Visual report](artifacts/rust-benchmark/issue/xlsx/report/comparison_report.md)** | | ||
| | Java | XLSX, DOCX | Library, CLI | Experimental | **[Java source](minipdf-java/)** | **[Visual report](artifacts/java-benchmark/issue/xlsx/report/comparison_report.md)** | | ||
| | Python | DOCX | Package, CLI | Experimental | **[Python guide](minipdf-python/README.md)** | **[Visual report](artifacts/python-benchmark/issue/xlsx/report/comparison_report.md)** | |
| | .NET | XLSX, DOCX, PPTX | Bibliothèque, CLI, binaires Native AOT | Stable | **[Guide .NET](README.nuget.md)** | **[Rapport visuel](../artifacts/dotnet-benchmark/issue/xlsx/report/comparison_report.md)** | | ||
| | Rust | XLSX, DOCX, PPTX | Crate, CLI | Expérimental | **[Guide Rust](../minipdf-rs/README.md)** | **[Rapport visuel](../artifacts/rust-benchmark/issue/xlsx/report/comparison_report.md)** | | ||
| | Java | XLSX, DOCX | Bibliothèque, CLI | Expérimental | **[Sources Java](../minipdf-java/)** | **[Rapport visuel](../artifacts/java-benchmark/issue/xlsx/report/comparison_report.md)** | | ||
| | Python | DOCX | Paquet, CLI | Expérimental | **[Guide Python](../minipdf-python/README.md)** | **[Rapport visuel](../artifacts/python-benchmark/issue/xlsx/report/comparison_report.md)** | |
| | .NET | XLSX, DOCX, PPTX | Libreria, CLI, binari Native AOT | Stabile | **[Guida .NET](README.nuget.md)** | **[Rapporto visivo](../artifacts/dotnet-benchmark/issue/xlsx/report/comparison_report.md)** | | ||
| | Rust | XLSX, DOCX, PPTX | Crate, CLI | Sperimentale | **[Guida Rust](../minipdf-rs/README.md)** | **[Rapporto visivo](../artifacts/rust-benchmark/issue/xlsx/report/comparison_report.md)** | | ||
| | Java | XLSX, DOCX | Libreria, CLI | Sperimentale | **[Sorgenti Java](../minipdf-java/)** | **[Rapporto visivo](../artifacts/java-benchmark/issue/xlsx/report/comparison_report.md)** | | ||
| | Python | DOCX | Pacchetto, CLI | Sperimentale | **[Guida Python](../minipdf-python/README.md)** | **[Rapporto visivo](../artifacts/python-benchmark/issue/xlsx/report/comparison_report.md)** | |
| | .NET | XLSX、DOCX、PPTX | ライブラリ、CLI、Native AOT バイナリ | 安定版 | **[.NET ガイド](README.nuget.md)** | **[視覚レポート](../artifacts/dotnet-benchmark/issue/xlsx/report/comparison_report.md)** | | ||
| | Rust | XLSX、DOCX、PPTX | Crate、CLI | 実験版 | **[Rust ガイド](../minipdf-rs/README.md)** | **[視覚レポート](../artifacts/rust-benchmark/issue/xlsx/report/comparison_report.md)** | | ||
| | Java | XLSX、DOCX | ライブラリ、CLI | 実験版 | **[Java ソース](../minipdf-java/)** | **[視覚レポート](../artifacts/java-benchmark/issue/xlsx/report/comparison_report.md)** | | ||
| | Python | DOCX | パッケージ、CLI | 実験版 | **[Python ガイド](../minipdf-python/README.md)** | **[視覚レポート](../artifacts/python-benchmark/issue/xlsx/report/comparison_report.md)** | |
| | .NET | XLSX, DOCX, PPTX | 라이브러리, CLI, Native AOT 바이너리 | 안정 | **[.NET 가이드](README.nuget.md)** | **[시각적 보고서](../artifacts/dotnet-benchmark/issue/xlsx/report/comparison_report.md)** | | ||
| | Rust | XLSX, DOCX, PPTX | Crate, CLI | 실험적 | **[Rust 가이드](../minipdf-rs/README.md)** | **[시각적 보고서](../artifacts/rust-benchmark/issue/xlsx/report/comparison_report.md)** | | ||
| | Java | XLSX, DOCX | 라이브러리, CLI | 실험적 | **[Java 소스](../minipdf-java/)** | **[시각적 보고서](../artifacts/java-benchmark/issue/xlsx/report/comparison_report.md)** | | ||
| | Python | DOCX | 패키지, CLI | 실험적 | **[Python 가이드](../minipdf-python/README.md)** | **[시각적 보고서](../artifacts/python-benchmark/issue/xlsx/report/comparison_report.md)** | |
| | .NET | XLSX、DOCX、PPTX | 库、CLI、Native AOT 二进制文件 | 稳定 | **[.NET 指南](README.nuget.md)** | **[视觉报告](../artifacts/dotnet-benchmark/issue/xlsx/report/comparison_report.md)** | | ||
| | Rust | XLSX、DOCX、PPTX | Crate、CLI | 实验性 | **[Rust 指南](../minipdf-rs/README.md)** | **[视觉报告](../artifacts/rust-benchmark/issue/xlsx/report/comparison_report.md)** | | ||
| | Java | XLSX、DOCX | 库、CLI | 实验性 | **[Java 源代码](../minipdf-java/)** | **[视觉报告](../artifacts/java-benchmark/issue/xlsx/report/comparison_report.md)** | | ||
| | Python | DOCX | 包、CLI | 实验性 | **[Python 指南](../minipdf-python/README.md)** | **[视觉报告](../artifacts/python-benchmark/issue/xlsx/report/comparison_report.md)** | |
| | .NET | XLSX、DOCX、PPTX | 程式庫、CLI、Native AOT 二進位檔 | 穩定 | **[.NET 指南](README.nuget.md)** | **[視覺報告](../artifacts/dotnet-benchmark/issue/xlsx/report/comparison_report.md)** | | ||
| | Rust | XLSX、DOCX、PPTX | Crate、CLI | 實驗性 | **[Rust 指南](../minipdf-rs/README.md)** | **[視覺報告](../artifacts/rust-benchmark/issue/xlsx/report/comparison_report.md)** | | ||
| | Java | XLSX、DOCX | 程式庫、CLI | 實驗性 | **[Java 原始碼](../minipdf-java/)** | **[視覺報告](../artifacts/java-benchmark/issue/xlsx/report/comparison_report.md)** | | ||
| | Python | DOCX | 套件、CLI | 實驗性 | **[Python 指南](../minipdf-python/README.md)** | **[視覺報告](../artifacts/python-benchmark/issue/xlsx/report/comparison_report.md)** | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects #136 by replacing the temporary
artifacts/benchmark/<language>/reportoutputs with the existing canonical per-language reports underartifacts/<language>-benchmark/issue/xlsx/report.The canonical reports use Microsoft 365 as the primary reference and include LibreOffice as the auxiliary reference.
Validation
git diff --cached --checkSummary by CodeRabbit
Documentation
Benchmark Reports