Contract and Harnesses for byte_add, byte_sub and byte_offset - #169
Merged
Conversation
- Also adds proofs verifying unit, int and composite types.
- Adds harnesses for int, unit, composite and slice types
Author
|
@feliperodri FYI |
jswrenn
reviewed
Nov 20, 2024
jswrenn
suggested changes
Nov 25, 2024
<*mut T>::byte_add, byte_sub and byte_offsetbyte_add, byte_sub and byte_offset
Member
|
@jswrenn could you give another round of review for this one? I believe they have addressed all your comments. |
jswrenn
approved these changes
Nov 29, 2024
jswrenn
left a comment
There was a problem hiding this comment.
Two final nits, which you're welcome to take or leave.
Thanks for the contribution!
jswrenn
suggested changes
Nov 30, 2024
…ting to unit type
stogaru
force-pushed
the
verify/ptr_mut_byte
branch
from
December 5, 2024 07:19
eea35b0 to
eab2c65
Compare
feliperodri
approved these changes
Dec 5, 2024
jswrenn
approved these changes
Dec 5, 2024
jswrenn
left a comment
There was a problem hiding this comment.
LGTM! Thank you for all the hard work on this.
carolynzech
enabled auto-merge (squash)
December 5, 2024 15:20
feliperodri
added a commit
that referenced
this pull request
Dec 9, 2024
…nd `byte_offset` (#188) Towards #76 This pull request impelments proof for contracts for `byte_add`, `byte_sub` and `byte_offset` for `<dyn Trait>`. Both `const` and `mut` versions are included. It serves as an addition to an existing [PR](#169) but is submitted separately to avoid disrupting the ongoing review process for that PR. --------- Co-authored-by: Surya Togaru <stogaru@andrew.cmu.edu> Co-authored-by: stogaru <143449212+stogaru@users.noreply.github.com> Co-authored-by: Felipe R. Monteiro <rms.felipe@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #76
Changes
<*mut T>::byte_add,<*mut T>::byte_suband<*mut T>::byte_offset.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.