Skip to content

Added <dyn Trait> Proof for Contracts for byte_add, byte_sub, and byte_offset - #188

Merged
feliperodri merged 33 commits into
model-checking:mainfrom
stogaru:verify/ptr_byte_dyn
Dec 9, 2024
Merged

Added <dyn Trait> Proof for Contracts for byte_add, byte_sub, and byte_offset#188
feliperodri merged 33 commits into
model-checking:mainfrom
stogaru:verify/ptr_byte_dyn

Conversation

@xsxszab

@xsxszab xsxszab commented Nov 27, 2024

Copy link
Copy Markdown

Towards #76

This pull request impelments proof for contracts for byte_add, byte_sub and byte_offset for <dyn Trait>. Both const and mut versions are included.

It serves as an addition to an existing PR but is submitted separately to avoid disrupting the ongoing review process for that PR.

@xsxszab
xsxszab marked this pull request as ready for review November 27, 2024 08:07
@xsxszab
xsxszab requested a review from a team as a code owner November 27, 2024 08:07
@feliperodri feliperodri self-assigned this Nov 27, 2024
@tautschnig

Copy link
Copy Markdown
Member

@xsxszab Please resolve conflicts.

Comment thread library/core/src/ptr/const_ptr.rs Outdated
Comment thread library/core/src/ptr/const_ptr.rs Outdated
Comment thread library/core/src/ptr/const_ptr.rs Outdated
Comment thread library/core/src/ptr/const_ptr.rs Outdated
Comment thread library/core/src/ptr/mut_ptr.rs Outdated
Comment thread library/core/src/ptr/mut_ptr.rs Outdated
Comment thread library/core/src/ptr/mut_ptr.rs Outdated
Comment thread library/core/src/ptr/mut_ptr.rs Outdated
@xsxszab
xsxszab marked this pull request as draft November 29, 2024 05:29

@feliperodri feliperodri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some clean up is required before merging it.

Comment thread library/core/src/ptr/const_ptr.rs Outdated
Comment thread library/core/src/ptr/const_ptr.rs Outdated
Comment thread library/core/src/ptr/const_ptr.rs Outdated
Comment thread library/core/src/ptr/mut_ptr.rs Outdated
Comment thread library/core/src/ptr/mut_ptr.rs Outdated
Comment thread library/core/src/ptr/mut_ptr.rs Outdated
@xsxszab
xsxszab marked this pull request as ready for review December 6, 2024 01:07
@xsxszab

xsxszab commented Dec 6, 2024

Copy link
Copy Markdown
Author

Please Note that PR #168 mistakenly removed mut proofs for unit, integer and composite types for add, sub and offset. The changes have been reverted as part of this PR during merging.

@feliperodri
feliperodri enabled auto-merge (squash) December 6, 2024 05:24

@feliperodri feliperodri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trigger review

auto-merge was automatically disabled December 9, 2024 17:41

Head branch was pushed to by a user without write access

@feliperodri feliperodri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@feliperodri
feliperodri enabled auto-merge (squash) December 9, 2024 18:51
@feliperodri
feliperodri merged commit 6077459 into model-checking:main Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants