Skip to content

Fix analysis findings and prep local Sonar runs - #5

Merged
mrmidi merged 1 commit into
mainfrom
codex/clang-analysis-fix-sweep
Mar 8, 2026
Merged

mrmidi merged 1 commit into
mainfrom
codex/clang-analysis-fix-sweep

Conversation

@mrmidi

@mrmidi mrmidi commented Mar 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • fix the ASFWDriver analyzer and targeted clang-tidy findings from the current sweep
  • clean the remaining in-repo warning noise in ASFWDriver/tests
  • refactor AsyncSubsystem::Start into smaller helpers
  • add local Sonar manual-analysis prep and runner

Verification

  • xcodebuild analyze for ASFWDriver
  • host test build (407/407)
  • manual Sonar scanner runner prepared for project-level scans once analysis is triggered

@mrmidi
mrmidi merged commit 1b1d09f into main Mar 8, 2026
1 of 2 checks passed
mrmidi added a commit that referenced this pull request Jun 12, 2026
Fix analysis findings and prep local Sonar runs
gdemontalivet pushed a commit to gdemontalivet/ASFireWire that referenced this pull request Aug 2, 2026
…ation

44100.md:
- §12: reverse-engineer RME FirefaceAudioDriver's 44.1 cadence — DCL-branch
  Bresenham (increment = rate/8000), closed-loop RX clock recovery via the
  +276 per-group target table and a 1/16 IIR estimate, and per-rate startup
  latency anchors. Behavioral/algorithm observations only (proprietary binary).
- Extend the IDA evidence index and add RME-specific open questions.
- Mark all open questions with status: mrmidi#6 RESOLVED (Linux cross-check),
  mrmidi#8 RESOLVED-by-decision (resync branch not needed under replay),
  mrmidi#12 RESOLVED design / capture-gated value; flag mrmidi#1–mrmidi#5 as legacy-DCL
  archaeology, not blockers.

SAMPLE_RATE_EXPANSION.md:
- §3: minimal TX cadence contract ({data/no-data, SYT}; DBC free; SYT =
  delta replay + per-rate phase re-anchor; payload separate; RX carries none)
  and what "device-as-master" does and does not remove.
- §8: consolidate the capture-gated items into one measurement (per-rate
  presentation lead + startup-prefix tolerance) in one gated session, partly
  self-instrumented via [TxSyt]/[Zts] traces; mrmidi#9/mrmidi#10 moot under replay.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
forkt69 pushed a commit to forkt69/ASFireWire that referenced this pull request Aug 28, 2026
Fix analysis findings and prep local Sonar runs
forkt69 pushed a commit to forkt69/ASFireWire that referenced this pull request Aug 28, 2026
…ation

44100.md:
- §12: reverse-engineer RME FirefaceAudioDriver's 44.1 cadence — DCL-branch
  Bresenham (increment = rate/8000), closed-loop RX clock recovery via the
  +276 per-group target table and a 1/16 IIR estimate, and per-rate startup
  latency anchors. Behavioral/algorithm observations only (proprietary binary).
- Extend the IDA evidence index and add RME-specific open questions.
- Mark all open questions with status: mrmidi#6 RESOLVED (Linux cross-check),
  mrmidi#8 RESOLVED-by-decision (resync branch not needed under replay),
  mrmidi#12 RESOLVED design / capture-gated value; flag mrmidi#1–mrmidi#5 as legacy-DCL
  archaeology, not blockers.

SAMPLE_RATE_EXPANSION.md:
- §3: minimal TX cadence contract ({data/no-data, SYT}; DBC free; SYT =
  delta replay + per-rate phase re-anchor; payload separate; RX carries none)
  and what "device-as-master" does and does not remove.
- §8: consolidate the capture-gated items into one measurement (per-rate
  presentation lead + startup-prefix tolerance) in one gated session, partly
  self-instrumented via [TxSyt]/[Zts] traces; mrmidi#9/mrmidi#10 moot under replay.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant