Skip to content

Let the deploy's anonymous probe pass through the reputation gate - #115

Merged
myxamediyar merged 1 commit into
mainfrom
deploy-smoke-check
Sep 23, 2026
Merged

myxamediyar merged 1 commit into
mainfrom
deploy-smoke-check

Conversation

@myxamediyar

@myxamediyar myxamediyar commented Sep 23, 2026 •

Copy link
Copy Markdown
Owner

The post-deploy "Check what is live" step curls one anonymous classification from the hosted runner. The free-traffic reputation gate can refuse a runner's IP with 403 proxy_requires_payment — the Worker answering with its own gate, not a broken deploy. The deploys for #113 and #114 were marked failed by exactly this, and curl --fail discarded the response body that would have shown it.

The step now:

  • always prints the probe's status and body, so a failure says what was answered;
  • passes with a ::notice:: when the answer is the gate's own 403 proxy_requires_payment;
  • still requires spam on a 200, and fails on any other status.

The funded "Check multidimensional classification end to end" step, skipped after the failure, runs again.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Improved deployment verification to provide clearer status information when checking live service behavior.
    • Added more informative handling for access restrictions caused by hosted runner network reputation, while continuing to flag unexpected responses as failures.

The post-deploy check curls one anonymous classification from the hosted
runner. The free-traffic reputation gate can refuse a runner's IP with 403
proxy_requires_payment, which is the Worker answering with its own gate,
not a broken deploy; the last two deploys were marked failed by it, and
`curl --fail` discarded the body that would have said so.

The probe now prints the status and body, passes with a notice on the
gate's own 403, still requires "spam" on a 200, and fails on anything
else. The funded end-to-end step that followed it runs again.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: f9181224-904f-439f-b4d4-e9fc48478134

📥 Commits

Reviewing files that changed from the base of the PR and between 5f69538 and 4ee8d5d.

📒 Files selected for processing (1)
  • .github/workflows/deploy.yml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The deploy workflow now captures and prints the live-check response. It accepts HTTP 200 with the "spam" label and HTTP 403 with proxy_requires_payment. Other responses fail the step.

Changes

Deploy probe handling

Layer / File(s) Summary
Live-check response classification
.github/workflows/deploy.yml
The step captures the HTTP status and prints the response body. It passes expected responses, reports the payment-gate case, and fails for other statuses or labels.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: mrmps

Merge Risk: ⚪ Minimal · up to 4ee8d

The deploy probe now reports its response and permits the expected reputation-gate response without masking other failures. No merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: updating the deploy's anonymous probe to handle the reputation gate. It is concise and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@myxamediyar
myxamediyar merged commit 9bee908 into main Sep 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant