Conversation
Thanks for opening this pull request! 🎉We really appreciate you taking the time to contribute, @dvd233. A maintainer will take a look as soon as they can. In the meantime, please make sure that:
If anything needs adjusting we'll leave comments here. Thanks again! |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe change extracts stackbar tooltip point conversion into a shared chart utility. The timeline chart uses the utility. Unit tests verify visual ordering, size, signed delta, and removed-segment handling. ChangesStackbar tooltip conversion
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The dependency-size tooltip now follows the chart’s visual stack while retaining delta and removed-segment behavior. The change is limited to tooltip presentation and has no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
graphieros
left a comment
There was a problem hiding this comment.
This can just be fixed by removing .toReversed() from stackbarTooltipPoints
|
Fixed in #3243 |
🔗 Linked issue
Fixes #3239
🧭 Context
The dependency-size chart and its tooltip showed the same stack in opposite orders, which made similarly colored segments difficult to match.
📚 Description
vue-data-ui's tooltip datapoint order, which already follows the visual stack from top to bottom.Screenshots
Testing
pnpm test -- --coverage.enabled=false— 2,919 passed, 5 skippedpnpm test:typespnpm vp run lintpnpm vp run test:browser:prebuilt— 266 passed, 1 skipped@babel/core@8.0.1dependency-size chart