Skip to content

fix: do not reverse order in Timeline tooltip - #3243

Merged
graphieros merged 1 commit into
mainfrom
roman/fix-3239
Sep 11, 2026
Merged

graphieros merged 1 commit into
mainfrom
roman/fix-3239

Conversation

@gameroman

Copy link
Copy Markdown
Member

🔗 Linked issue

Fixes #3239

🧭 Context

📚 Description

@vercel

vercel Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
npmx.dev Ready Ready Preview Sep 11, 2026 4:43pm UTC
2 Skipped Deployments
Project Deployment Actions Updated
docs.npmx.dev Ignored Ignored Sep 11, 2026 4:43pm UTC
npmx-lunaria Ignored Ignored Sep 11, 2026 4:43pm UTC

Request Review

@gameroman
gameroman requested a review from a team September 11, 2026 16:41
@coderabbitai

coderabbitai Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 976b3072-648b-407c-bf88-ccff328c704b

📥 Commits

Reviewing files that changed from the base of the PR and between f9fedd2 and 8074246.

📒 Files selected for processing (1)
  • app/components/Package/TimelineChart.vue
💤 Files with no reviewable changes (1)
  • app/components/Package/TimelineChart.vue

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the stack bar chart tooltip order so dependency segments now appear in their original sequence.

Walkthrough

The stackbar tooltip now returns dependency segments in their original filtered order. This aligns the tooltip order with the chart order.

Changes

Tooltip dependency order

Layer / File(s) Summary
Preserve tooltip segment order
app/components/Package/TimelineChart.vue
Removed .toReversed() from the stackbarTooltipPoints pipeline. Filtered tooltip points now retain their original order.

Priority: ⬇️ Low

Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 80742

Tooltip package ordering now remains consistent with the chart, with no unresolved merge risk identified.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states that the Timeline tooltip order should not be reversed. It uses a conventional commit prefix and matches the main change.
Description check ✅ Passed The description links issue #3239, which relates to the pull request objective. Although the context and detailed description sections are empty, the description is not unrelated to the changeset.
Linked Issues check ✅ Passed The change satisfies #3239. stackbarTooltipPoints no longer calls .toReversed(), so the dependency-size tooltip keeps the datapoint order supplied by the chart. dependencySegments defines the ch…
Out of Scope Changes check ✅ Passed The pull request changes one line in app/components/Package/TimelineChart.vue. The change only removes the tooltip reversal required by #3239. No unrelated implementation or test changes are present…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch roman/fix-3239

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@graphieros graphieros left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😉

@graphieros
graphieros added this pull request to the merge queue Sep 11, 2026
Merged via the queue into main with commit b854533 Sep 11, 2026
28 checks passed
@graphieros
graphieros deleted the roman/fix-3239 branch September 11, 2026 16:58

This branch was successfully deployed

1 active deployment
Preview – npmx.dev — 8074246e Deployed Sep 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sort packages in "dependency size" list consistently with chart

2 participants