feat: add mention users for TipTap - #3060
Merged
Merged
Conversation
JammingBen
reviewed
Aug 12, 2026
JammingBen
left a comment
Member
There was a problem hiding this comment.
Do we want to highlight the mentioned users with a special color, like on tiptap.dev?
Member
Yes 馃檶 |
Member
|
@tammi-23, FYI: opencloud-eu/libre-graph-api#64 SRY |
3 of 9 tasks
tammi-23
force-pushed
the
issues/3012
branch
from
September 2, 2026 06:12
83f45ae to
7446a80
Compare
The mention notification moved from `POST /collaboration/notify` to
`POST /v1.0/users/{user-id}/teamwork/sendActivityNotification`. That
endpoint takes a single recipient, so every mentioned user gets its own
request and only the recipients that failed are kept for the next retry.
tammi-23
force-pushed
the
issues/3012
branch
from
September 2, 2026 07:24
7446a80 to
a90dd70
Compare
JammingBen
requested changes
Sep 3, 2026
JammingBen
left a comment
Member
There was a problem hiding this comment.
A few issue I noticed:
- The own name is missing the highlight. For
alanit looks like this after getting notified:
-
When you type
@, select a user, remove the line again and then save, the user still gets a notification. -
Should we limit the functionality to
ocnoteandmd? I don't think you want to mention users e.g. in a code document. The same inside code blocks, I think we should disable it as well for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will add #3012