Skip to content

Split canopy regression matrix into independent tests - #790

Merged
Aymericr merged 1 commit into
mainfrom
fix/canopy-ci-matrix-cases
Sep 9, 2026
Merged

Aymericr merged 1 commit into
mainfrom
fix/canopy-ci-matrix-cases

Conversation

@Aymericr

@Aymericr Aymericr commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

The exhaustive canopy rendering regression covered 240 geometry combinations inside one test with a shared 15-second deadline. Two consecutive private-editor main CI attempts timed out at 15,141.06 ms and 15,387.96 ms, even though the same test passed required PR CI at 13,029.10 ms.

This registers each existing form/angle/turn/reverse/projection-flip combination as an independently named test. Every case keeps the same scene construction, overlap calculation, geometry disposal, and zero-overlap requirement. The change does not raise a timeout, remove cases, weaken assertions, or claim faster runtime.

Validation:

  • CI-matching Bun 1.3.14: three focused runs, 250/250 passing each
  • Exact matrix check: 240 expected unique cases, zero missing/extra/duplicate
  • Full @pascal-app/nodes suite: 2,336 passed, 1 existing skip
  • Repository Biome check: 2,086 files passed
  • git diff --check: passed

Local timing cannot reproduce GitHub runner load; the fix addresses reliability by removing the shared matrix deadline.


Note

Low Risk
Test-only refactor with identical assertions and coverage; no production code paths change.

Overview
Replaces one 240-case canopy roof overlap regression with 240 individually named test() entries in canopy-rendering-regression.test.ts, so each form/angle/turn/reverse/projection-flip combination runs under its own test instead of a single nested loop.

Behavior is unchanged: same buildRuns setup, separatedTopOverlapCount, geometry disposal, and expect(overlaps).toBe(0). The aggregate failures array and the 15s timeout on the monolithic test are removed in favor of per-case failures and default per-test timeouts, addressing CI flakiness from the shared deadline on a heavy matrix.

Reviewed by Cursor Bugbot for commit 458ae29. Bugbot is set up for automated code reviews on this repo. Configure here.

@pascal

pascal Bot commented Sep 9, 2026

Copy link
Copy Markdown

I hit an error while handling your request (Model unavailable on AI Gateway free tier: Free tier users do not have access to this model. Upgrade to paid credits at https://vercel.com/d?to=%2F%5Bteam%5D%2F%7E%2Fai%3Fmodal%3Dtop-up for unrestricted…).

Please try again, rephrase, or reach out if it keeps failing.

Error id: e1d390c9-2b0f-4104-985a-da161e75782c

@Aymericr
Aymericr merged commit 35f8665 into main Sep 9, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant