Split canopy regression matrix into independent tests - #790
Merged
Merged
Conversation
|
I hit an error while handling your request (Model unavailable on AI Gateway free tier: Free tier users do not have access to this model. Upgrade to paid credits at https://vercel.com/d?to=%2F%5Bteam%5D%2F%7E%2Fai%3Fmodal%3Dtop-up for unrestricted…). Please try again, rephrase, or reach out if it keeps failing. Error id: e1d390c9-2b0f-4104-985a-da161e75782c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exhaustive canopy rendering regression covered 240 geometry combinations inside one test with a shared 15-second deadline. Two consecutive private-editor main CI attempts timed out at 15,141.06 ms and 15,387.96 ms, even though the same test passed required PR CI at 13,029.10 ms.
This registers each existing form/angle/turn/reverse/projection-flip combination as an independently named test. Every case keeps the same scene construction, overlap calculation, geometry disposal, and zero-overlap requirement. The change does not raise a timeout, remove cases, weaken assertions, or claim faster runtime.
Validation:
@pascal-app/nodessuite: 2,336 passed, 1 existing skipgit diff --check: passedLocal timing cannot reproduce GitHub runner load; the fix addresses reliability by removing the shared matrix deadline.
Note
Low Risk
Test-only refactor with identical assertions and coverage; no production code paths change.
Overview
Replaces one 240-case canopy roof overlap regression with 240 individually named
test()entries incanopy-rendering-regression.test.ts, so each form/angle/turn/reverse/projection-flip combination runs under its own test instead of a single nested loop.Behavior is unchanged: same
buildRunssetup,separatedTopOverlapCount, geometry disposal, andexpect(overlaps).toBe(0). The aggregatefailuresarray and the 15s timeout on the monolithic test are removed in favor of per-case failures and default per-test timeouts, addressing CI flakiness from the shared deadline on a heavy matrix.Reviewed by Cursor Bugbot for commit 458ae29. Bugbot is set up for automated code reviews on this repo. Configure here.