Skip to content

Split canopy regression matrix into independent tests #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aymericr merged 1 commit into from
Sep 9, 2026
Merged

Split canopy regression matrix into independent tests #790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 15 additions & 21 deletions packages/nodes/src/lean-to-extension/canopy-rendering-regression.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,19 +183,18 @@ describe('freestanding canopy rendered-joint regressions', () => {
for (const geometry of result.geometries) geometry.dispose()
})

test('all canopy forms keep finite, non-overlapping roofs across turns and orientations', () => {
const failures: string[] = []
for (const form of ['mono', 'gable', 'butterfly'] as const) {
for (const angle of [1, 2, 5, 15, 30, 45, 60, 75, 89, 90]) {
for (const turn of [-1, 1]) {
const radians = (turn * angle * Math.PI) / 180
const forward: Point[] = [
[0, 0],
[8, 0],
[8 + 8 * Math.cos(radians), 8 * Math.sin(radians)],
]
for (const reverse of [false, true]) {
for (const flipProjection of [false, true]) {
for (const form of ['mono', 'gable', 'butterfly'] as const) {
for (const angle of [1, 2, 5, 15, 30, 45, 60, 75, 89, 90]) {
for (const turn of [-1, 1]) {
for (const reverse of [false, true]) {
for (const flipProjection of [false, true]) {
test(`${form} angle=${angle} turn=${turn} reverse=${reverse} flip=${flipProjection} has no separated roof overlap`, () => {
const radians = (turn * angle * Math.PI) / 180
const forward: Point[] = [
[0, 0],
[8, 0],
[8 + 8 * Math.cos(radians), 8 * Math.sin(radians)],
]
const points = reverse ? [...forward].reverse() : forward
const result = buildRuns(
`${form}_${angle}_${turn}_${reverse}_${flipProjection}`,
Expand All @@ -205,19 +204,14 @@ describe('freestanding canopy rendered-joint regressions', () => {
flipProjection,
)
const overlaps = separatedTopOverlapCount(result.geometries)
if (overlaps > 0) {
failures.push(
`${form} angle=${angle} turn=${turn} reverse=${reverse} flip=${flipProjection} has ${overlaps} separated overlaps`,
)
}
for (const geometry of result.geometries) geometry.dispose()
}
expect(overlaps).toBe(0)
})
}
}
}
}
expect(failures).toEqual([])
}, 15000)
}

test('maximum canopy overhangs keep connected, non-overlapping corner roofs', () => {
const patch = {
Expand Down
Loading