Skip to content

Update Xdebug to version 3.0 - #650

Merged
GrahamCampbell merged 3 commits into
php-build:masterfrom
ste93cry:feature/update-xdebug-to-version-3.0
Nov 27, 2020
Merged

GrahamCampbell merged 3 commits into
php-build:masterfrom
ste93cry:feature/update-xdebug-to-version-3.0

Conversation

@ste93cry

Copy link
Copy Markdown
Contributor

As per title, I updated Xdebug to version 3.0.0 for all compatible PHP versions (7.2 - 8.0)

@GrahamCampbell

Copy link
Copy Markdown
Member

Please leave PHP 7.2 on xdebug 2 because PHPUnit doesn't work with xdebug 3 on PHP 7.2.

@ste93cry

Copy link
Copy Markdown
Contributor Author

PHPUnit doesn't work with xdebug 3 on PHP 7.2.

Changes made, may I ask you if there is some issue related to this that you can point me to?

@GrahamCampbell

Copy link
Copy Markdown
Member

PHPUnit has now done a U-turn after saying for weeks they would not support Xdebug 3 in PHPUnit 8.x, they implemented it today... Sorry to ask this, but could you revert the last commit, making your PR how it was originally.

…ith Xdebug 3 on that version"

This reverts commit 6b4d134.
@ste93cry

Copy link
Copy Markdown
Contributor Author

Done 👍

@GrahamCampbell
GrahamCampbell merged commit 4b837f7 into php-build:master Nov 27, 2020
@ste93cry
ste93cry deleted the feature/update-xdebug-to-version-3.0 branch November 27, 2020 17:03
@GrahamCampbell

Copy link
Copy Markdown
Member

Excellent. Thanks!

@GrahamCampbell

Copy link
Copy Markdown
Member

🚢

BanzaiMan pushed a commit to BanzaiMan/php-build that referenced this pull request Nov 30, 2020
* Update Xdebug to version 3.0

* Revert update on PHP 7.2 because of PHPUnit incompatibility with Xdebug 3 on that version

* Revert "Revert update on PHP 7.2 because of PHPUnit incompatibility with Xdebug 3 on that version"

This reverts commit 6b4d134.
@thefrosty

Copy link
Copy Markdown

Is there a flag that can be set in Travis to lock the xdebug to a specific version?

@ste93cry

ste93cry commented Dec 2, 2020

Copy link
Copy Markdown
Contributor Author

I didn't see such flag anywhere so I don't think it exists. However, I just realized that with my changes I will break all projects because the configuration of Xdebug 2 is not compatible with the one of Xdebug 3, so either it should be possible to decide which version of Xdebug it is gonna be installed to use or the change should be reverted on all PHP versions older than 8.0 or we should create new definitions for all versions that installs the newer version of Xdebug

@thefrosty

Copy link
Copy Markdown

I had to lock in my PHP version on Travis to 7.3.24 as 7.3.25 now has Xdebug 3 and we haven't tested it and was breaking our builds. In case anyone else has that same issue, just set PHP to one minor release back.

@ste93cry

ste93cry commented Dec 2, 2020

Copy link
Copy Markdown
Contributor Author

I had to lock in my PHP version on Travis to 7.3.24 as 7.3.25 now has Xdebug 3

@GrahamCampbell, my changes are indeed breaking people's apps so let me know how we want to solve the problem, I proposed a few solutions a few comments above. I would honestly prefer to be able to choose which version of Xdebug to install for each version, but I'm not sure how to implement it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants