Skip to content

Revert all PHP versions lower than 8.0 to Xdebug 2.9 - #653

Closed
ste93cry wants to merge 1 commit into
php-build:masterfrom
ste93cry:revert-xdebug-to-version-2.9-on-php-lower-than-8.0
Closed

ste93cry wants to merge 1 commit into
php-build:masterfrom
ste93cry:revert-xdebug-to-version-2.9-on-php-lower-than-8.0

Conversation

@ste93cry

@ste93cry ste93cry commented Dec 3, 2020 •

Copy link
Copy Markdown
Contributor

This PR reverts the update of Xdebug to version 3 that I did in #650 on all PHP versions lower than 8.0. While Travis CI luckily did not rebuilt their existing images, it published the new ones that did get the upgrade in ac92f4e and this caused all projects that were running fine with Xdebug 2 and PHPUnit 7 to broke unexpectly

@GrahamCampbell

Copy link
Copy Markdown
Member

You can use PHPUnit 8 on PHP 7.2.

@GrahamCampbell

Copy link
Copy Markdown
Member

If travis or you want to PR customisation of xdebug version, I'd review that.

@ste93cry

ste93cry commented Dec 3, 2020

Copy link
Copy Markdown
Contributor Author

You can use PHPUnit 8 on PHP 7.2

I understand, but isn't this a breaking change? I mean, up to a certain patch version of PHP you get Xdebug 2.9 while after that same version you get Xdebug 3.0. I understand that it's not your fault, but we cannot expect people to update all their projects to run PHPUnit 8 just because betwen patch releases Xdebug becames incompatible, can we?

@GrahamCampbell

Copy link
Copy Markdown
Member

Yes, it is a breaking change, and we have always upgraded images to the very latest version of xdebug they can run. This is really an issue with Travis, and not us. It is up to them if they want to upgrade to the latest version of this package, and get any breaking changes made since the last version they were using.

@ste93cry

ste93cry commented Dec 3, 2020 •

Copy link
Copy Markdown
Contributor Author

we have always upgraded images to the very latest version of xdebug they can run

Looking at the commit history I didn't find a case where Xdebug got upgraded to a new major versions for all images already released and for a new minor release of PHP. I understand it's not your business what Travis does, but knowing that a lot of people use it and consequently they depend from this package, I have a different opinion on this matter. Anyway, if it's fine for you then ok

@GrahamCampbell

Copy link
Copy Markdown
Member

Looking at the commit history I didn't find a case where Xdebug got upgraded to a new major versions for all images already released and for a new minor release of PHP.

That is just a co-incidence. All images always use the very latest version that is supported.

I understand it's not your business what Travis does, but knowing that a lot of people use it and consequently they depend from this package, I have a different opinion on this matter.

It is totally up to Travis what version of this package they use, and up to them to decide if they want to upgrade or not. This package is provided on an "as is" basis, without warrantee. Since Travis do not fund this package, they have no say over the direction of the package, although I will not be unreasonable (I would accept PRs to allow customisation of the xdebug version, but I am not going to implement this myself for free).

@GrahamCampbell

Copy link
Copy Markdown
Member

In fact, I am actually very close to abandoning this project entirely, given there is no funding, and no active core team to help out with day-to-day. I don't even use it myself anymore.

@ste93cry

ste93cry commented Dec 3, 2020

Copy link
Copy Markdown
Contributor Author

Since Travis do not fund this package, they have no say over the direction

Just to clarify, I do not work for Travis and I spoke just for myself. If they thought the recent changes were a problem I'm pretty sure they would have already did something. A project I contribute to has just been impacted by my changes here and I tried the easy way to fix the issue by rolling back the breaking change here. I didn't meant to be rude or whatever else. I honestly didn't even know this project was the basis of the PHP images on Travis, I started looking how it was working behind the scene just because I was looking for the PHP8 support. Anyway, for what's worth, thank you for the hard work you put into this repository all this time 💪

@ste93cry
ste93cry deleted the revert-xdebug-to-version-2.9-on-php-lower-than-8.0 branch December 3, 2020 22:44
@jarstelfox

Copy link
Copy Markdown

@GrahamCampbell, Thank you for all the work you have put into this project.

In fact, I am actually very close to abandoning this project entirely, given there is no funding, and no active core team to help out with day-to-day.

I would recommend putting out a call to the community looking for people to take over the maintainer role. Who knows, maybe the project lives on and is something off your plate.

Thank you again.

@GrahamCampbell

Copy link
Copy Markdown
Member

Every time I do this, a couple of people show interest, then drop off after a few weeks or months. ;(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants