Datetimepicker - #811
Conversation
1db3565 to
571fa86
Compare
32eff19 to
e952129
Compare
e4f9a1e to
32b0963
Compare
|
@nicolaskruchten ready for review : ) |
|
|
||
| return fullValueIsDate ? ( | ||
| <UnconnectedText {...this.props} placeholder={'yyyy-mm-dd 00:00:00.00'} /> | ||
| <UnconnectedDateTimePicker {...this.props} placeholder={'yyyy-mm-dd 00:00:00.00'} /> |
There was a problem hiding this comment.
the placeholder should be YYYY-MM-DD hh:mm:ss.xxx or something like that, not a mix of letters and numbers :)
| use: ['style-loader', 'css-loader', 'sass-loader'], | ||
| }, | ||
| { | ||
| test: /\.(woff(2)?|ttf|eot|svg)(\?v=\d+\.\d+\.\d+)?$/, |
There was a problem hiding this comment.
what's this for? just the little icons?
There was a problem hiding this comment.
yes its for the little arrow icons that come with the Datetimepicker
|
Let's add these to the axis range UI as well please. |
|
I'm not sure what's doing this, but the dev bundle size on master is 35MB and on this branch it's 39.3MB (just from the log output of webpack) ... is this datepicker really heavy? is fonts? there's 7k lines of CSS here in the datepicker style file... |
yes.. i'll try to reduce those |
9721cf4 to
2f337fa
Compare
|
bundle size with react-day-picker, a looot better |
|
way better :) |
|
the original library's calendar picker looks like: changed it to, using RCE dropdowns: |
da12ee4 to
fb64f41
Compare
|
sorry about that @nicolaskruchten, should be ok now, was doing some cleanups and messed up the behaviour |
|
Two comments about the validation:
|
|
|
2045af7 to
aa7737b
Compare
|
should be ok now |
|
|
3064d03 to
a462aac
Compare
|
bingo! 💃 |
off
on
