The dev-version counter is a tested pure function - #239
Merged
Conversation
No behavior change. Merging this also publishes the first dev build since 0.8.0, which repairs the stale dev dist-tag (0.6.0-dev.23, engine 0.1.1) currently blocking prisma-cli's rc.5 publish. Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
wmadden
approved these changes
Aug 18, 2026
This was referenced Aug 18, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No behavior change:
determine-version.ts's dev-counter logic moves tonextDevVersionin the tested utils module, with four tests.Why now: merging this pushes main, which publishes the first dev build since the 0.8.0 release —
0.8.0-dev.1, peering engine 0.2.0. Composer'sdevdist-tag currently still points at0.6.0-dev.23(engine 0.1.1), and that stale tag is failing dev-channel conformance in prisma-cli's publish run, blocking the8.0.0-rc.5release that repairsprisma@next. The durable fix (a release push also publishes its dev build, per the dev-tag-parity brief) follows separately.🤖 Generated with Claude Code