Skip to content

chore: migrate the biome config to 2.5.4 and format the version-utils test - #240

Merged
wmadden merged 1 commit into
mainfrom
chore/biome-2.5.4-config
Aug 20, 2026
Merged

chore: migrate the biome config to 2.5.4 and format the version-utils test#240
wmadden merged 1 commit into
mainfrom
chore/biome-2.5.4-config

Conversation

@kristof-siket

Copy link
Copy Markdown
Contributor

`main` is red on `pnpm lint` since #239 (CI run 12:27Z: `failure`), and every PR that updates from main inherits it (e.g. #238).

Two errors, both fixed with biome's own tooling, no behaviour change:

  • `biome.jsonc` declared schema `2.5.3` while `@biomejs/biome` is `2.5.4` → biome rejected the config. `pnpm biome migrate --write`.
  • `scripts/determine-version-utils.test.ts` (new in The dev-version counter is a tested pure function #239) was committed unformatted: import order + line width. `pnpm biome check --write` on that file; `node --test` still 15/15.

`pnpm lint` is clean on this branch (817 files, 0 errors). The remaining warnings/infos on main (`noUndeclaredEnvVars`, `no-bare-cast`, one info-level `useTemplate`) are pre-existing and non-blocking; left alone.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0ce47cf8-ccb3-48fb-9b50-1a950247454c

📥 Commits

Reviewing files that changed from the base of the PR and between 6b2b5ae and a666e14.

📒 Files selected for processing (2)
  • biome.jsonc
  • scripts/determine-version-utils.test.ts

Included review availability: 0 reviews are currently available. Based on recent review activity, included reviews refill at 2 per hour.


Summary by CodeRabbit

  • Chores

    • Updated the Biome configuration schema reference.
  • Style

    • Reformatted a test utility import for improved readability.

Walkthrough

The pull request updates the Biome schema reference from version 2.5.3 to 2.5.4. It also reformats a named import in scripts/determine-version-utils.test.ts. The imported symbols and test behavior remain unchanged.

Merge Risk: ⚪ Minimal · up to a666e

This PR updates the Biome schema version and formats one test file without changing behavior; lint and tests are reported clean, so no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies both primary changes: the Biome schema update and test formatting.
Description check ✅ Passed The description directly explains the lint failures, the two fixes, and the test and lint results.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/biome-2.5.4-config
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch chore/biome-2.5.4-config

Comment @coderabbitai help to get the list of available commands.

@wmadden wmadden left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏🏻

@pkg-pr-new

pkg-pr-new Bot commented Aug 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@prisma/composer@240
npm i https://pkg.pr.new/@prisma/composer-cli@240
npm i https://pkg.pr.new/@prisma/composer-prisma-cloud@240

commit: d2b152f

@kristof-siket
kristof-siket force-pushed the chore/biome-2.5.4-config branch from a666e14 to d881d97 Compare August 18, 2026 12:57
@wmadden
wmadden enabled auto-merge (squash) August 20, 2026 10:20
@biomejs/biome moved to 2.5.4 while biome.jsonc still declared the 2.5.3
schema, so every `pnpm lint` run warns that the configuration version does
not match the CLI. `pnpm biome migrate --write`; no rule or behaviour change.

Signed-off-by: Kristof Siket <siket@prisma.io>
@wmadden
wmadden force-pushed the chore/biome-2.5.4-config branch from d881d97 to d2b152f Compare August 20, 2026 10:21
@wmadden
wmadden merged commit adab58b into main Aug 20, 2026
16 checks passed
@wmadden
wmadden deleted the chore/biome-2.5.4-config branch August 20, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants