update: external link icon - #4611
Merged
Merged
Conversation
added 2 commits
March 28, 2023 10:38
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
This PR changes the following pages (Vercel Preview Deploy links): Changed Vercel links
(Note that links will only be valid after Vercel preview deploy succeeded) |
Contributor
|
Looks good to me but would be great if we can do the Lost Pixel check on this PR. |
Contributor
|
This PR probably requires the following redirects to be added to vercel.json:
|
meletj
approved these changes
Jun 1, 2023
Contributor
|
@ruheni before we merge this PR, could you pls check on these two pages as they contain a lot of external links and it might look busy with the icon (see screenshots from Percy): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe this PR
Docs has external links that are not identifiable. This PR aims to explore a solution.
Changes
Added an external icon link, in addition to
target="__blank" rel="noopener"attributes to the renderedaelement for the external link.What issue does this fix?
Fixes #530
Any other relevant information
N/a