Skip to content

chore: convert active Preview features list into a table - #4830

Merged
ruheni merged 2 commits into
mainfrom
preview-feature-table
Jun 1, 2023
Merged

chore: convert active Preview features list into a table#4830
ruheni merged 2 commits into
mainfrom
preview-feature-table

Conversation

@ruheni

@ruheni ruheni commented May 31, 2023

Copy link
Copy Markdown
Contributor

This PR improves the aesthetic presentation of the active Preview features. We intend to add an external link icon for external links in the near future. Some spacing between the external links, in list of active Preview features, helps in making it less overwhelming (with the external link + icons)
Related PR:#4611

Current:
CleanShot 2023-05-31 at 22 48 04@2x

New:

CleanShot 2023-05-31 at 22 46 41@2x

@vercel

vercel Bot commented May 31, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2023 4:21pm

@github-actions

github-actions Bot commented May 31, 2023

Copy link
Copy Markdown
Contributor

This PR changes the following pages (Vercel Preview Deploy links):

Changed Vercel links

(Note that links will only be valid after Vercel preview deploy succeeded)

@github-actions

Copy link
Copy Markdown
Contributor

This PR probably requires the following redirects to be added to vercel.json:

  • This PR does not change any pages in a way that would require a redirect.

@ruheni
ruheni requested review from janpio, meletj and nikolasburk May 31, 2023 20:45
@ruheni ruheni changed the title chore: convert Preview features list into a table chore: convert active Preview features list into a table May 31, 2023

@meletj meletj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I noticed you changed preview to Preview on most pages but not this one /docs/concepts/components/preview-features

@ruheni

ruheni commented Jun 1, 2023

Copy link
Copy Markdown
Contributor Author

I've updated "preview" to "Preview" on that page.

@ruheni
ruheni merged commit 55a4919 into main Jun 1, 2023
@ruheni
ruheni deleted the preview-feature-table branch June 1, 2023 18:01
- [`clientExtensions`](/concepts/components/prisma-client/client-extensions) since release [4.7.0](https://github.com/prisma/prisma/releases/tag/4.7.0) - [Submit feedback](https://github.com/prisma/prisma/issues/16500)
- [`views`](/concepts/components/prisma-schema/views) since release [4.9.0](https://github.com/prisma/prisma/releases/tag/4.9.0) - [Submit feedback](https://github.com/prisma/prisma/issues/17335)
- `jsonProtocol` since release [4.11.0](https://github.com/prisma/prisma/releases/tag/4.11.0) - [Submit feedback](https://github.com/prisma/prisma/issues/18095)
| Feature | Released into Preview | Feedback issue |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Feedback Issue" is not actually centered in the rendered output, but the "Submit feedback" links are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants