Skip to content

fix(web): use upload icon for disabled push action - #2

Merged
rynfar merged 1 commit into
pylonfrom
upstream/2026-08-11-push-icon
Aug 11, 2026
Merged

fix(web): use upload icon for disabled push action#2
rynfar merged 1 commit into
pylonfrom
upstream/2026-08-11-push-icon

Conversation

@rynfar

@rynfar rynfar commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

The Push quick action in GitActionsControl had no icon case of its own, so it fell through to the generic InfoIcon. It now renders CloudUploadIcon, matching how push is already drawn elsewhere in the same file (icon === "push" and open_publish both use it).

Direct follow-up to #6194 (clearer pull action icon), adopted earlier today — same function, finishing the job.

Cherry-picked from upstream 2db08457f2f4eaaa713a067b2ea480ca2b583025 (pingdotgg/t3code#6207), clean, one line.

Web typecheck, lint, and format clean.

Model: Claude Opus 5 (1M context). Harness: Claude Code.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith with what you need. Autofix is disabled.

(cherry picked from commit 2db08457f2f4eaaa713a067b2ea480ca2b583025)
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS labels Aug 11, 2026
@github-actions

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 11.4 KiB 11.3 KiB −4 B (−0.0%) 15.1 KiB
Codex Thread snapshot wire 5.5 KiB 5.5 KiB +3 B (+0.1%) 7.3 KiB
Codex Live turn WebSocket wire 5.9 KiB 5.9 KiB −7 B (−0.1%) 7.8 KiB
Codex Live turn WebSocket decoded 49.7 KiB 49.7 KiB 0 B (0.0%) 66.4 KiB
Codex Live turn messages 16 16 0 (0.0%) 21
Claude Total thread wire 11.4 KiB 11.4 KiB +13 B (+0.1%) 15.1 KiB
Claude Thread snapshot wire 5.5 KiB 5.5 KiB −1 B (−0.0%) 7.3 KiB
Claude Live turn WebSocket wire 5.9 KiB 5.9 KiB +14 B (+0.2%) 7.8 KiB
Claude Live turn WebSocket decoded 50.6 KiB 50.6 KiB 0 B (0.0%) 66.4 KiB
Claude Live turn messages 16 16 0 (0.0%) 21

Baseline: c53f5b8 · PR result: 3dc5ba5 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 94.6 KiB
  • Claude decoded thread snapshot: 95.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@rynfar
rynfar merged commit bf2020c into pylon Aug 11, 2026
11 checks passed
@rynfar
rynfar deleted the upstream/2026-08-11-push-icon branch August 11, 2026 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant