feat(web): use OKLCH for theme palettes - #3
Merged
Conversation
(cherry picked from commit 083fa4ab24c464ddf01e5b7ab22135d1ebdc120b)
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves palette generation to OKLCH so generated theme ramps are perceptually uniform. Rewrites
themePalette.ts(+592),index.css, and the boot script inindex.html, and updatesThemeColorPickerand the VS Code theme importer.Adds two dependencies:
culoriand@types/culori.Cherry-picked from upstream
083fa4ab24c464ddf01e5b7ab22135d1ebdc120b(pingdotgg/t3code#6036). Clean, despite five files where Pylon had diverged.Why it applies cleanly:
#6183(theme-aware environment artwork) is an ancestor of this commit, and Pylon adopted that earlier today. Taking these out of order would have fought.index.htmlchecked Pylon-first. The diff adds no visible T3 branding and leaves<title>Pylon (Alpha)</title>untouched. Thet3-chat-darktheme id and the boot-script comments that mention T3 Chat were already onpylon(5 references before this change, none added) and are compatibility identifiers — renaming them would orphan saved themes.Also carries the ledger entry for this batch, covering both this PR and #2, and advances
reviewed-throughto2db08457f. DEF-1 and DEF-2 re-evaluated and still deferred: the date gate is 2026-08-25 and the churn check is non-empty.Verification
themePalette,themeBoot,vscodeThemeImport, andSidebarStageBackdroppass (78 tests). Web typecheck, lint, and format clean.Worth a human eye before merge: tests confirm the math, not the appearance. A color-space change can compute correctly and still shift how the five built-in themes look, so this deserves one pass in a real client.
Model: Claude Opus 5 (1M context). Harness: Claude Code.
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.