Conversation
Implement TaskManager remove/update/sortBy and string truncate; fix wordCount whitespace handling, email TLD length, URL port rejection, divide-by-zero, and relative-date day rounding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remove,update(partial, returns false for unknown id),sortBy(returns a new array; priority high→low, createdAt oldest first)wordCountsplits on/\s+/; implementtruncate(word boundary, ellipsis counts toward maxLength)isEmailaccepts long TLDs (linear-time regex);isUrlaccepts ports (http/https scheme allowlist retained)dividethrows on division by zeroformatRelativeusesMath.roundfor daysVerification
bun test: 60 pass / 0 fail (was 44/16)tsc --noEmit: cleanAssumptions
sortBy('status')(untested) uses workflow order pending → in_progress → completed.truncatewithmaxLength <= 3hard-cuts without ellipsis.