Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/calculator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ export function multiply(a: number, b: number): number {
return a * b
}

// BUG: Division by zero is not handled
export function divide(a: number, b: number): number {
if (b === 0) {
throw new Error("Division by zero")
}
return a / b
}
5 changes: 2 additions & 3 deletions src/date-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,14 @@
* Format a date as a human-readable relative string.
* e.g. "2 days ago", "just now", "in 3 hours"
*
* BUG: off-by-one — uses Math.floor where Math.round is needed for days,
* causing "1 day ago" to appear for anything from 12h to 47h.
* Day counts are rounded to the nearest day, so 36 hours reads "2 days ago".
*/
export function formatRelative(date: Date, now: Date = new Date()): string {
const diffMs = now.getTime() - date.getTime()
const diffSec = diffMs / 1000
const diffMin = diffSec / 60
const diffHours = diffMin / 60
const diffDays = Math.floor(diffHours / 24) // BUG: should be Math.round
const diffDays = Math.round(diffHours / 24)

if (Math.abs(diffSec) < 60) return "just now"
if (Math.abs(diffMin) < 60) {
Expand Down
23 changes: 17 additions & 6 deletions src/string-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,21 @@ export function reverse(str: string): string {
return str.split("").reverse().join("")
}

// TODO: implement truncate — should truncate at a word boundary, with "..."
// counting toward maxLength. Return unchanged if str.length <= maxLength.
/**
* Truncate a string at a word boundary. The "..." ellipsis counts toward
* maxLength, so the result is never longer than maxLength. Returns the string
* unchanged if it already fits.
*/
export function truncate(str: string, maxLength: number): string {
throw new Error("not implemented")
if (str.length <= maxLength) return str

const ellipsis = "..."
if (maxLength <= ellipsis.length) return str.slice(0, Math.max(0, maxLength))

const slice = str.slice(0, maxLength - ellipsis.length)
const lastSpace = slice.lastIndexOf(" ")
const content = lastSpace > 0 ? slice.slice(0, lastSpace) : slice
return content.trimEnd() + ellipsis
}

export function slugify(str: string): string {
Expand All @@ -24,8 +35,8 @@ export function slugify(str: string): string {
.replace(/^-|-$/g, "")
}

// BUG: This doesn't handle multiple consecutive spaces
export function wordCount(str: string): number {
if (!str.trim()) return 0
return str.split(" ").length
const trimmed = str.trim()
if (!trimmed) return 0
return trimmed.split(/\s+/).length
}
34 changes: 26 additions & 8 deletions src/task-manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,20 +52,38 @@ export class TaskManager {
return true
}

// TODO: implement — remove a task by id, return true if removed, false if not found
remove(id: string): boolean {
throw new Error("not implemented")
return this.tasks.delete(id)
}

// TODO: implement — update title/description/priority of a task
// return true if updated, false if not found
update(id: string, changes: Partial<Pick<Task, "title" | "description" | "priority">>): boolean {
throw new Error("not implemented")
const task = this.tasks.get(id)
if (!task) return false
if (changes.title !== undefined) task.title = changes.title
if (changes.description !== undefined) task.description = changes.description
if (changes.priority !== undefined) task.priority = changes.priority
return true
}

// TODO: implement — return all tasks sorted by the given field
// priority sort order: high > medium > low
/**
* Return a new array of all tasks sorted by the given field.
* priority: high > medium > low. createdAt: oldest first.
* status: pending > in_progress > completed (workflow order).
* Sort is stable, so equal keys keep insertion order.
*/
sortBy(field: "priority" | "createdAt" | "status"): Task[] {
throw new Error("not implemented")
const priorityRank: Record<Priority, number> = { high: 0, medium: 1, low: 2 }
const statusRank: Record<Status, number> = { pending: 0, in_progress: 1, completed: 2 }

return Array.from(this.tasks.values()).sort((a, b) => {
switch (field) {
case "priority":
return priorityRank[a.priority] - priorityRank[b.priority]
case "status":
return statusRank[a.status] - statusRank[b.status]
case "createdAt":
return a.createdAt.getTime() - b.createdAt.getTime()
}
})
}
}
14 changes: 7 additions & 7 deletions src/validator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,24 @@
/**
* Returns true if the string is a valid email address.
*
* BUG: the regex does not allow subdomains (e.g. user@mail.example.com fails)
* and rejects valid TLDs longer than 4 chars (e.g. .museum, .travel).
* Supports multi-label domains (user@mail.example.com) and TLDs of any length
* (.museum, .travel). Each domain label excludes whitespace, "@" and "." so the
* pattern matches in linear time (no catastrophic backtracking).
*/
export function isEmail(value: string): boolean {
// BUG: too restrictive — missing subdomain support and long TLDs
return /^[^\s@]+@[^\s@]+\.[a-zA-Z]{2,4}$/.test(value)
return /^[^\s@]+@[^\s@.]+(\.[^\s@.]+)*\.[a-zA-Z]{2,}$/.test(value)
}

/**
* Returns true if the string is a valid URL (http or https).
*
* BUG: rejects URLs with ports (e.g. http://localhost:3000)
* An explicit port is permitted (e.g. http://localhost:3000); only the scheme
* is restricted, to avoid accepting ftp:, file: or javascript: URLs.
*/
export function isUrl(value: string): boolean {
try {
const url = new URL(value)
// BUG: only allows http/https but also rejects valid port usage
return (url.protocol === "http:" || url.protocol === "https:") && url.port === ""
return url.protocol === "http:" || url.protocol === "https:"
} catch {
return false
}
Expand Down
Loading