Fix P-521 coordinate length calculation#29
Merged
Conversation
The P-521 curve has 521 bits (65.125 bytes), but JWK EC coordinates must be zero-padded to 66 bytes. Using `crv.Params().BitSize/8` truncates to 65 bytes. Updating the calculation to round up
leelynne
requested changes
Jul 21, 2025
leelynne
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for fixing this! One request for a comment.
leelynne
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The P-521 curve has 521 bits (65.125 bytes), but JWK EC coordinates must be zero-padded to 66 bytes. Using
crv.Params().BitSize/8truncates to 65 bytes. Updating the calculation to round up. We need 66 bytes to store 521 bits.