Skip to content

Fix P-521 coordinate length calculation #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leelynne merged 2 commits into from
Jul 28, 2025
Merged

Fix P-521 coordinate length calculation #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4209dd
Fix P-521 coordinate length calculation
getvictor Jul 13, 2025
7fdf9e7
Update jwk.go
getvictor Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion keyutil/jwk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,8 @@ func (ec *jwkEC) params() (crv elliptic.Curve, byteLen int, e error) {
default:
return nil, 0, fmt.Errorf("Unsupported ECC curve '%s'", ec.Curve)
}
return crv, crv.Params().BitSize / 8, nil
// The P-521 curve has 521 bits (65.125 bytes), so we must round up to get the bytes. We need 66 bytes to store 521 bits.
return crv, (crv.Params().BitSize + 7) / 8, nil
Comment thread
getvictor marked this conversation as resolved.
}

func (ec *jwkEC) PublicKey() (*ecdsa.PublicKey, error) {
Expand Down
Loading