refactor: establish DOMPlatform folder feature - #313
Merged
Conversation
Collaborator
Author
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
from
August 4, 2026 17:31
ac6324d to
0aafabb
Compare
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
3 times, most recently
from
August 5, 2026 12:34
f36c85b to
9b42cfc
Compare
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
from
August 5, 2026 13:40
9b42cfc to
935bd3d
Compare
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
from
August 5, 2026 13:57
935bd3d to
560041c
Compare
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
2 times, most recently
from
August 5, 2026 14:30
1bd4272 to
8948e6f
Compare
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
from
August 5, 2026 14:50
8948e6f to
26185b8
Compare
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
2 times, most recently
from
August 5, 2026 15:45
33243ee to
1810562
Compare
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
from
August 5, 2026 17:39
1810562 to
53472db
Compare
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
from
August 6, 2026 14:52
53472db to
b6388e3
Compare
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
from
August 6, 2026 14:58
b6388e3 to
797588f
Compare
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
from
August 7, 2026 13:44
f8e948a to
62eb735
Compare
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
from
August 7, 2026 13:45
62eb735 to
dd80e48
Compare
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
from
August 7, 2026 13:50
dd80e48 to
98792a0
Compare
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
from
August 7, 2026 13:54
98792a0 to
1de0075
Compare
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
from
August 7, 2026 13:56
1de0075 to
1aa2ee8
Compare
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
from
August 7, 2026 13:57
1aa2ee8 to
7e3c463
Compare
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
from
August 7, 2026 13:58
7e3c463 to
be7a991
Compare
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
from
August 7, 2026 13:59
be7a991 to
66c103d
Compare
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
from
August 7, 2026 14:00
66c103d to
58c9a5a
Compare
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
from
August 7, 2026 14:00
58c9a5a to
7da8103
Compare
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
from
August 7, 2026 14:03
7da8103 to
8fc581e
Compare
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
from
August 7, 2026 14:04
8fc581e to
ebdccd9
Compare
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
from
August 7, 2026 14:04
ebdccd9 to
877c3ad
Compare
jderochervlk
force-pushed
the
codex/option5-dom-platform
branch
from
August 7, 2026 14:07
877c3ad to
0046c74
Compare
jderochervlk
added a commit
that referenced
this pull request
Aug 7, 2026
Tracking issue: #342 ## Stack context Part 4 of the Option 5 folder-feature stack. - Previous: #313 - Next: another dependency-clean domain folder Review this PR as the incremental diff against #313. ## Summary - rename `src/URL` to the target `src/url` folder - keep the complete folder on the unqualified internal `URL` feature - preserve the supported `WebAPI.URL` implication of `WebAPI.DOM` plus `URL` - leave the flat `WebAPI.URL` and `WebAPI.URLSearchParams` module paths unchanged The internal `UrlTypes` helper remains in the same folder and is not added to the public module list. ## Temporary state - this PR does not introduce compatibility aliases, file exclusions, or module slices; the URL folder and feature ownership are final - the broader public-feature graph remains transitional until the legacy qualified source features are replaced by the remaining unqualified folder features ## Review focus - confirming the change is limited to physical folder ownership - preserving the existing public feature implication and module paths ## Verification - `node_modules/.bin/rescript clean` - `node_modules/.bin/rescript build --prod --features DOM,URL` - `npm run build` - `npm test` - `npm run format:check` - `git diff --check`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #342
Stack context
Part 3 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #312.
Summary
src/dom-platformfolder on the unqualified internalDOMPlatformfeatureDOMException,DOMStringList,DOMStringMap, andDOMTokenListinto that complete folderWebAPI.DOMPlatformfeature with itsWebAPI.EventdependencyDOMImplementationis intentionally not included: its current signatures embedDOMTreenode types, so placing it here would make DOMPlatform depend on DOMNodes while DOMNodes already depends on DOMPlatform.Temporary state
DOM.domException,DOM.domStringList, andDOM.domTokenList; the final cleanup layer will make the owning modules authoritative after all consumers have movedsrc/DOMsource entry is still taggedWebAPI.DOM, so qualified public-feature selective builds are not yet at their final minimal closureDOMStringMapremains an internal supporting module, matching its existing visibilityReview focus
WebAPI.DOMPlatform -> WebAPI.Event -> WebAPI.DOMpublic implicationVerification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,DOMPlatformnpm run buildnpm testnpm run format:checkgit diff --check