Skip to content

refactor: establish DOMPlatform folder feature - #313

Merged
jderochervlk merged 1 commit into
mainfrom
codex/option5-dom-platform
Aug 7, 2026
Merged

refactor: establish DOMPlatform folder feature#313
jderochervlk merged 1 commit into
mainfrom
codex/option5-dom-platform

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 3 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #312.

Summary

  • add the target src/dom-platform folder on the unqualified internal DOMPlatform feature
  • move DOMException, DOMStringList, DOMStringMap, and DOMTokenList into that complete folder
  • add the supported WebAPI.DOMPlatform feature with its WebAPI.Event dependency
  • move the public interface declarations from the legacy broad DOM source entry without changing their flat module paths

DOMImplementation is intentionally not included: its current signatures embed DOMTree node types, so placing it here would make DOMPlatform depend on DOMNodes while DOMNodes already depends on DOMPlatform.

Temporary state

  • the moved modules still reference foundational compatibility types such as DOM.domException, DOM.domStringList, and DOM.domTokenList; the final cleanup layer will make the owning modules authoritative after all consumers have moved
  • the legacy broad src/DOM source entry is still tagged WebAPI.DOM, so qualified public-feature selective builds are not yet at their final minimal closure
  • DOMStringMap remains an internal supporting module, matching its existing visibility

Review focus

  • the dependency-safe DOMPlatform membership
  • the WebAPI.DOMPlatform -> WebAPI.Event -> WebAPI.DOM public implication
  • preserving flat public module paths and source behavior

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features DOM,Event,DOMPlatform
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: ac6324d6db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch from ac6324d to 0aafabb Compare August 4, 2026 17:31
@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch 3 times, most recently from f36c85b to 9b42cfc Compare August 5, 2026 12:34
@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch from 9b42cfc to 935bd3d Compare August 5, 2026 13:40
@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch from 935bd3d to 560041c Compare August 5, 2026 13:57
@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch 2 times, most recently from 1bd4272 to 8948e6f Compare August 5, 2026 14:30
@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch from 8948e6f to 26185b8 Compare August 5, 2026 14:50
@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch 2 times, most recently from 33243ee to 1810562 Compare August 5, 2026 15:45
@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch from 1810562 to 53472db Compare August 5, 2026 17:39
@jderochervlk
jderochervlk requested review from brnrdog and tsnobip August 6, 2026 14:45
@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch from 53472db to b6388e3 Compare August 6, 2026 14:52
@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch from b6388e3 to 797588f Compare August 6, 2026 14:58
@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch from f8e948a to 62eb735 Compare August 7, 2026 13:44
@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch from 62eb735 to dd80e48 Compare August 7, 2026 13:45
@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch from dd80e48 to 98792a0 Compare August 7, 2026 13:50
@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch from 98792a0 to 1de0075 Compare August 7, 2026 13:54
@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch from 1de0075 to 1aa2ee8 Compare August 7, 2026 13:56
@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch from 1aa2ee8 to 7e3c463 Compare August 7, 2026 13:57
@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch from 7e3c463 to be7a991 Compare August 7, 2026 13:58
@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch from be7a991 to 66c103d Compare August 7, 2026 13:59
@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch from 66c103d to 58c9a5a Compare August 7, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch from 58c9a5a to 7da8103 Compare August 7, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch from 7da8103 to 8fc581e Compare August 7, 2026 14:03
@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch from 8fc581e to ebdccd9 Compare August 7, 2026 14:04
@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch from ebdccd9 to 877c3ad Compare August 7, 2026 14:04
Base automatically changed from codex/option5-event-folder to main August 7, 2026 14:07
@jderochervlk
jderochervlk force-pushed the codex/option5-dom-platform branch from 877c3ad to 0046c74 Compare August 7, 2026 14:07
@jderochervlk
jderochervlk merged commit ef0b6db into main Aug 7, 2026
2 checks passed
jderochervlk added a commit that referenced this pull request Aug 7, 2026
Tracking issue: #342

## Stack context

Part 4 of the Option 5 folder-feature stack.

- Previous: #313
- Next: another dependency-clean domain folder

Review this PR as the incremental diff against #313.

## Summary

- rename `src/URL` to the target `src/url` folder
- keep the complete folder on the unqualified internal `URL` feature
- preserve the supported `WebAPI.URL` implication of `WebAPI.DOM` plus
`URL`
- leave the flat `WebAPI.URL` and `WebAPI.URLSearchParams` module paths
unchanged

The internal `UrlTypes` helper remains in the same folder and is not
added to the public module list.

## Temporary state

- this PR does not introduce compatibility aliases, file exclusions, or
module slices; the URL folder and feature ownership are final
- the broader public-feature graph remains transitional until the legacy
qualified source features are replaced by the remaining unqualified
folder features

## Review focus

- confirming the change is limited to physical folder ownership
- preserving the existing public feature implication and module paths

## Verification

- `node_modules/.bin/rescript clean`
- `node_modules/.bin/rescript build --prod --features DOM,URL`
- `npm run build`
- `npm test`
- `npm run format:check`
- `git diff --check`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants