Skip to content

refactor: establish URL folder feature - #314

Merged
jderochervlk merged 1 commit into
mainfrom
codex/option5-url-folder
Aug 7, 2026
Merged

refactor: establish URL folder feature#314
jderochervlk merged 1 commit into
mainfrom
codex/option5-url-folder

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 4 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #313.

Summary

  • rename src/URL to the target src/url folder
  • keep the complete folder on the unqualified internal URL feature
  • preserve the supported WebAPI.URL implication of WebAPI.DOM plus URL
  • leave the flat WebAPI.URL and WebAPI.URLSearchParams module paths unchanged

The internal UrlTypes helper remains in the same folder and is not added to the public module list.

Temporary state

  • this PR does not introduce compatibility aliases, file exclusions, or module slices; the URL folder and feature ownership are final
  • the broader public-feature graph remains transitional until the legacy qualified source features are replaced by the remaining unqualified folder features

Review focus

  • confirming the change is limited to physical folder ownership
  • preserving the existing public feature implication and module paths

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features DOM,URL
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 752a746208

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch 2 times, most recently from fca3f13 to 926752f Compare August 5, 2026 12:14
@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch from 926752f to e236e53 Compare August 5, 2026 12:31
@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch from e236e53 to 742adaf Compare August 5, 2026 12:34
@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch 4 times, most recently from 6bc7ffd to 9a62190 Compare August 5, 2026 14:30
@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch from 9a62190 to adba5bc Compare August 5, 2026 14:50
@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch 2 times, most recently from cbd8ad7 to fc9c21c Compare August 5, 2026 15:45
@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch from fc9c21c to 6f3d6d8 Compare August 5, 2026 17:39
@jderochervlk
jderochervlk requested review from brnrdog and tsnobip August 6, 2026 14:45
@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch from 6f3d6d8 to a1144fa Compare August 6, 2026 14:52
@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch from a1144fa to 59ceed0 Compare August 6, 2026 14:58
@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch from 59ceed0 to 5466d4f Compare August 6, 2026 15:04
@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch from 7a2a348 to f7df56b Compare August 7, 2026 13:45
@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch from f7df56b to ec47a29 Compare August 7, 2026 13:50
@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch from ec47a29 to ebb8fc2 Compare August 7, 2026 13:54
@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch from ebb8fc2 to ce0cac8 Compare August 7, 2026 13:56
@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch from ce0cac8 to f7ce8d2 Compare August 7, 2026 13:57
@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch from f7ce8d2 to 6905ec3 Compare August 7, 2026 13:58
@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch from 6905ec3 to fd1cfb4 Compare August 7, 2026 13:59
@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch from fd1cfb4 to 2b0765c Compare August 7, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch from 2b0765c to 887601a Compare August 7, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch from 887601a to 91aeded Compare August 7, 2026 14:03
@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch from 91aeded to 3029acb Compare August 7, 2026 14:04
@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch from 3029acb to d834d63 Compare August 7, 2026 14:04
@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch from d834d63 to c19a54b Compare August 7, 2026 14:07
Base automatically changed from codex/option5-dom-platform to main August 7, 2026 14:09
@jderochervlk
jderochervlk force-pushed the codex/option5-url-folder branch from c19a54b to e5cb4a4 Compare August 7, 2026 14:09
@jderochervlk
jderochervlk merged commit b87091e into main Aug 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants