refactor: establish ViewTransitions folder feature - #316
Merged
Conversation
Collaborator
Author
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16b0709e9b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
2 times, most recently
from
August 5, 2026 12:14
788ef48 to
f8b2ef6
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
from
August 5, 2026 12:31
f8b2ef6 to
8e82fe0
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
from
August 5, 2026 12:34
8e82fe0 to
7e9f84f
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
3 times, most recently
from
August 5, 2026 14:00
7f89a05 to
b3e20dc
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
2 times, most recently
from
August 5, 2026 14:50
245b13b to
9ba1761
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
from
August 5, 2026 15:08
9ba1761 to
483bb0e
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
from
August 5, 2026 15:45
483bb0e to
0e326cd
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
from
August 5, 2026 17:39
0e326cd to
25c4ee3
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
from
August 6, 2026 14:52
25c4ee3 to
44be903
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
from
August 6, 2026 14:58
44be903 to
a7faf5d
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
from
August 7, 2026 13:44
ad9fb74 to
f6b2b07
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
from
August 7, 2026 13:45
f6b2b07 to
c8760b5
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
from
August 7, 2026 13:50
c8760b5 to
84e9fd8
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
from
August 7, 2026 13:54
84e9fd8 to
8f5a8a9
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
from
August 7, 2026 13:56
8f5a8a9 to
b916249
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
from
August 7, 2026 13:57
b916249 to
471f1af
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
from
August 7, 2026 13:58
471f1af to
1942dd8
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
from
August 7, 2026 13:59
1942dd8 to
579ca16
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
from
August 7, 2026 14:00
579ca16 to
84697bf
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
from
August 7, 2026 14:00
84697bf to
6b64696
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
from
August 7, 2026 14:03
6b64696 to
67271e9
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
from
August 7, 2026 14:04
67271e9 to
32f02e7
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
from
August 7, 2026 14:04
32f02e7 to
8d255f2
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
from
August 7, 2026 14:07
8d255f2 to
a17839f
Compare
jderochervlk
force-pushed
the
codex/option5-view-transitions-folder
branch
from
August 7, 2026 14:09
a17839f to
a3637dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #342
Stack context
Part 6 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #315.
Summary
src/ViewTransitionsto the targetsrc/view-transitionsfolderViewTransitionsfeatureWebAPI.ViewTransitionsfeature with itsWebAPI.EventdependencyWebAPI.ViewTransitionmoduleThe internal
ViewTransitionsTypeshelper stays private inside the complete folder.Temporary state
Review focus
WebAPI.ViewTransitions -> WebAPI.Event + ViewTransitionsimplicationVerification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,ViewTransitionsnpm run buildnpm testnpm run format:checkgit diff --check