Skip to content

refactor: establish ViewTransitions folder feature - #316

Merged
jderochervlk merged 1 commit into
mainfrom
codex/option5-view-transitions-folder
Aug 7, 2026
Merged

refactor: establish ViewTransitions folder feature#316
jderochervlk merged 1 commit into
mainfrom
codex/option5-view-transitions-folder

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 6 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #315.

Summary

  • rename src/ViewTransitions to the target src/view-transitions folder
  • change the folder to the unqualified internal ViewTransitions feature
  • add the supported WebAPI.ViewTransitions feature with its WebAPI.Event dependency
  • preserve the flat public WebAPI.ViewTransition module

The internal ViewTransitionsTypes helper stays private inside the complete folder.

Temporary state

  • this PR does not introduce compatibility aliases, file exclusions, or module slices; its folder and feature ownership are final
  • helper-type colocation remains deferred to the final cleanup layer

Review focus

  • the WebAPI.ViewTransitions -> WebAPI.Event + ViewTransitions implication
  • unchanged public module path and binding signatures
  • complete folder ownership

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features DOM,Event,ViewTransitions
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 16b0709e9b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rescript.json
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch 2 times, most recently from 788ef48 to f8b2ef6 Compare August 5, 2026 12:14
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch from f8b2ef6 to 8e82fe0 Compare August 5, 2026 12:31
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch from 8e82fe0 to 7e9f84f Compare August 5, 2026 12:34
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch 3 times, most recently from 7f89a05 to b3e20dc Compare August 5, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch 2 times, most recently from 245b13b to 9ba1761 Compare August 5, 2026 14:50
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch from 9ba1761 to 483bb0e Compare August 5, 2026 15:08
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch from 483bb0e to 0e326cd Compare August 5, 2026 15:45
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch from 0e326cd to 25c4ee3 Compare August 5, 2026 17:39
@jderochervlk
jderochervlk requested review from brnrdog and tsnobip August 6, 2026 14:45
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch from 25c4ee3 to 44be903 Compare August 6, 2026 14:52
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch from 44be903 to a7faf5d Compare August 6, 2026 14:58
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch from ad9fb74 to f6b2b07 Compare August 7, 2026 13:44
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch from f6b2b07 to c8760b5 Compare August 7, 2026 13:45
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch from c8760b5 to 84e9fd8 Compare August 7, 2026 13:50
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch from 84e9fd8 to 8f5a8a9 Compare August 7, 2026 13:54
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch from 8f5a8a9 to b916249 Compare August 7, 2026 13:56
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch from b916249 to 471f1af Compare August 7, 2026 13:57
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch from 471f1af to 1942dd8 Compare August 7, 2026 13:58
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch from 1942dd8 to 579ca16 Compare August 7, 2026 13:59
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch from 579ca16 to 84697bf Compare August 7, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch from 84697bf to 6b64696 Compare August 7, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch from 6b64696 to 67271e9 Compare August 7, 2026 14:03
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch from 67271e9 to 32f02e7 Compare August 7, 2026 14:04
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch from 32f02e7 to 8d255f2 Compare August 7, 2026 14:04
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch from 8d255f2 to a17839f Compare August 7, 2026 14:07
@jderochervlk
jderochervlk force-pushed the codex/option5-view-transitions-folder branch from a17839f to a3637dd Compare August 7, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants