refactor: establish Crypto folder feature - #317
Merged
Conversation
Collaborator
Author
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac809614fc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
from
August 4, 2026 17:31
ac80961 to
8b2c9b2
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
from
August 5, 2026 12:14
8b2c9b2 to
4511edb
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
from
August 5, 2026 12:31
4511edb to
bcc8e3c
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
from
August 5, 2026 12:34
bcc8e3c to
1758866
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
2 times, most recently
from
August 5, 2026 13:57
1756d67 to
973ac89
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
2 times, most recently
from
August 5, 2026 14:30
eb7e05b to
61892b8
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
from
August 5, 2026 14:50
61892b8 to
859a8af
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
2 times, most recently
from
August 5, 2026 15:45
fa1cd34 to
63bfc20
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
from
August 5, 2026 17:39
63bfc20 to
abf585f
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
from
August 6, 2026 14:52
abf585f to
0e35d88
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
from
August 7, 2026 13:44
39dd36f to
15b1dfa
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
from
August 7, 2026 13:45
15b1dfa to
3791a30
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
from
August 7, 2026 13:50
3791a30 to
a7a9ff9
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
from
August 7, 2026 13:54
a7a9ff9 to
1b6c902
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
from
August 7, 2026 13:56
1b6c902 to
2022056
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
from
August 7, 2026 13:57
2022056 to
317e363
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
from
August 7, 2026 13:58
317e363 to
9f341a7
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
from
August 7, 2026 13:59
9f341a7 to
f84320d
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
from
August 7, 2026 14:00
f84320d to
b28153e
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
from
August 7, 2026 14:00
b28153e to
beefe2d
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
from
August 7, 2026 14:03
beefe2d to
19e74a6
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
from
August 7, 2026 14:04
19e74a6 to
e547da6
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
from
August 7, 2026 14:04
e547da6 to
bd47b90
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
from
August 7, 2026 14:07
bd47b90 to
ba01e40
Compare
jderochervlk
force-pushed
the
codex/option5-crypto-folder
branch
from
August 7, 2026 14:09
ba01e40 to
3481762
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #342
Stack context
Part 7 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #316.
Summary
src/WebCryptoto the targetsrc/cryptofolderCryptofeatureWebAPI.Cryptofeature with itsWebAPI.DOMdependencyWebAPI.CryptoandWebAPI.SubtleCryptomodulesThe internal
WebCryptoTypeshelper remains private inside the complete folder.Temporary state
coreuntil the final ownership cleanup determines whether that broadly shared type should stay foundationalReview focus
WebAPI.Crypto -> WebAPI.DOM + CryptoimplicationVerification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Cryptonpm run buildnpm testnpm run format:checkgit diff --check