Conversation
mjcarroll
force-pushed
the
mjcarroll/windows-compiler-cache-v2
branch
from
September 9, 2026 21:45
2b22f6f to
c49f32d
Compare
mjcarroll
force-pushed
the
mjcarroll/windows-ninja
branch
from
September 9, 2026 21:57
fb3ad92 to
70e12c9
Compare
mjcarroll
force-pushed
the
mjcarroll/windows-compiler-cache-v2
branch
from
September 9, 2026 21:57
c49f32d to
a929858
Compare
mjcarroll
force-pushed
the
mjcarroll/windows-ninja
branch
from
September 14, 2026 21:08
70e12c9 to
224ba3b
Compare
mjcarroll
force-pushed
the
mjcarroll/windows-compiler-cache-v2
branch
from
September 14, 2026 21:08
a929858 to
77c9598
Compare
mjcarroll
force-pushed
the
mjcarroll/windows-ninja
branch
from
September 23, 2026 20:24
224ba3b to
c1790f5
Compare
mjcarroll
force-pushed
the
mjcarroll/windows-compiler-cache-v2
branch
from
September 23, 2026 20:24
77c9598 to
255403b
Compare
CMake ignores CMAKE_<LANG>_COMPILER_LAUNCHER under the Visual Studio generator, so this is needed before Windows CI can use a compiler cache. Ninja is single-config, so default CMAKE_BUILD_TYPE to Release when it is unset, matching the previous --config Release. Packaging jobs keep the Visual Studio generator. Ninja's object paths are longer and overrun MAX_PATH on some rosidl sources, so subst the workspace onto W:. ninja comes from the buildfarm environment in ros2/ros2#1854. Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com> Assisted-by: Claude Code (Claude Opus 5)
Export CMAKE_C_COMPILER_LAUNCHER, CMAKE_CXX_COMPILER_LAUNCHER and RUSTC_WRAPPER instead of passing -D, so they also reach ament_vendor sub-builds, which only forward an allow-list of CMake variables. try_compile() defaults to Debug, whose /Zi sccache can't cache, so build it as Release. The cache lives in .sccache in the Jenkins workspace, which persists between builds and is separate per job. sccache comes from the buildfarm environment in ros2/ros2#1854. Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com> Assisted-by: Claude Code (Claude Opus 5)
mjcarroll
force-pushed
the
mjcarroll/windows-ninja
branch
from
September 28, 2026 19:38
c1790f5 to
eff50b4
Compare
mjcarroll
force-pushed
the
mjcarroll/windows-compiler-cache-v2
branch
from
September 28, 2026 19:38
255403b to
4474e24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Run Windows compilations through sccache. Stacked on #900.
CMAKE_C_COMPILER_LAUNCHER,CMAKE_CXX_COMPILER_LAUNCHERandRUSTC_WRAPPERare exported rather than passed as-D, so they reachament_vendorsub-builds too.CMAKE_TRY_COMPILE_CONFIGURATION=Release, since sccache can't cache Debug's/Zi..sccachein the Jenkins workspace: it persists between builds and is separate per job.sccache --show-statsis printed before and after the build.Blocked on ros2/ros2#1854, and on gazebosim/gz-cmake#586:
gz_math_vendorandgz_utils_vendorhardcode/Zi, which fails to compile under sccache.Is this user-facing behavior change?
No
Did you use Generative AI?
Yes, Claude Code (Claude Opus 5).
Additional Information