Build Windows CI with Ninja - #900
Merged
Merged
Conversation
mjcarroll
force-pushed
the
mjcarroll/windows-ninja
branch
from
September 9, 2026 21:57
fb3ad92 to
70e12c9
Compare
Member
Author
|
Unspecified Type (Release): |
mjcarroll
force-pushed
the
mjcarroll/windows-ninja
branch
from
September 14, 2026 21:08
70e12c9 to
224ba3b
Compare
Contributor
|
New CI (looks like it took 5.5 hours): |
clalancette
reviewed
Sep 23, 2026
mjcarroll
force-pushed
the
mjcarroll/windows-ninja
branch
from
September 23, 2026 20:24
224ba3b to
c1790f5
Compare
Member
Author
|
One more without the buildspace change: |
clalancette
approved these changes
Sep 26, 2026
CMake ignores CMAKE_<LANG>_COMPILER_LAUNCHER under the Visual Studio generator, so this is needed before Windows CI can use a compiler cache. Ninja is single-config, so default CMAKE_BUILD_TYPE to Release when it is unset, matching the previous --config Release. Packaging jobs keep the Visual Studio generator. Ninja's object paths are longer and overrun MAX_PATH on some rosidl sources, so subst the workspace onto W:. ninja comes from the buildfarm environment in ros2/ros2#1854. Signed-off-by: Michael Carroll <mjcarroll.oss@gmail.com> Assisted-by: Claude Code (Claude Opus 5)
mjcarroll
force-pushed
the
mjcarroll/windows-ninja
branch
from
September 28, 2026 19:38
c1790f5 to
eff50b4
Compare
Member
Author
|
One more |
Member
Author
|
With ros2/rosidl_python#270: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switch Windows CI from the Visual Studio generator to Ninja. CMake ignores
CMAKE_<LANG>_COMPILER_LAUNCHERunder Visual Studio, so this is a prerequisite for the compiler cache in #899.CMAKE_BUILD_TYPEdefaults toReleasewhen unset, matching the previous--config Release. Packaging stays on Visual Studio.MAX_PATHon some rosidl sources, so the build space isband the workspace issubsted ontoW:.ninjacomes from thebuildfarmpixi environment, so the image installs and runs-e buildfarm.Depends on ros2/ros2#1854.
Is this user-facing behavior change?
No
Did you use Generative AI?
Yes, Claude Code (Claude Opus 5).
Additional Information
An earlier revision passed
test_ci_windowstogether with #899; the current head needs a rerun.