Add test creating two content filter topics with the same topic name - #2546
Merged
Merged
Conversation
Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
This was referenced May 30, 2024
fujitatomoya
reviewed
Jun 1, 2024
fujitatomoya
left a comment
Collaborator
There was a problem hiding this comment.
lgtm with green CI.
fujitatomoya
approved these changes
Jun 1, 2024
Contributor
|
Contributor
|
ahcorde
approved these changes
Jun 3, 2024
ahcorde
pushed a commit
that referenced
this pull request
Jun 4, 2024
…2546) Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
This was referenced Jun 5, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the proper test in
rclcppthat checks for a successful creation of two content filter topics for the same topic name.