Skip to content

Add test creating two content filter topics with the same topic name - #2549

Merged
fujitatomoya merged 1 commit into
rollingfrom
ahcorde/rolling/2546
Jun 4, 2024
Merged

Add test creating two content filter topics with the same topic name #2549
fujitatomoya merged 1 commit into
rollingfrom
ahcorde/rolling/2546

Conversation

@ahcorde

@ahcorde ahcorde commented Jun 4, 2024

Copy link
Copy Markdown
Contributor

I wrongly merged this PR #2546 on master. This PR targets rolling

@Mario-DL @ahcorde
Add test creating two content filter topics with the same topic name (#…
60a55ab 
…2546)

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
@ahcorde

ahcorde commented Jun 4, 2024

Copy link
Copy Markdown
Contributor Author
  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya approved these changes Jun 4, 2024
View reviewed changes

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

@fujitatomoya
fujitatomoya merged commit 7c09688 into rolling Jun 4, 2024
@delete-merged-branch
delete-merged-branch Bot deleted the ahcorde/rolling/2546 branch June 4, 2024 23:22
@fujitatomoya

fujitatomoya commented Jun 5, 2024

Copy link
Copy Markdown
Collaborator

@Mergifyio backport iron humble jazzy

@mergify

mergify Bot commented Jun 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

backport iron humble jazzy

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Jun 5, 2024
@ahcorde @Mario-DL @mergify
Add test creating two content filter topics with the same topic name (#…
11143f8 
…2546) (#2549)

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
(cherry picked from commit 7c09688)
@mergify mergify Bot mentioned this pull request Jun 5, 2024
Merged
mergify Bot pushed a commit that referenced this pull request Jun 5, 2024
@ahcorde @Mario-DL @mergify
Add test creating two content filter topics with the same topic name (#…
077f365 
…2546) (#2549)

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
(cherry picked from commit 7c09688)
@mergify mergify Bot mentioned this pull request Jun 5, 2024
Merged
mergify Bot pushed a commit that referenced this pull request Jun 5, 2024
@ahcorde @Mario-DL @mergify
Add test creating two content filter topics with the same topic name (#…
9c4ec4e 
…2546) (#2549)

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
(cherry picked from commit 7c09688)
@mergify mergify Bot mentioned this pull request Jun 5, 2024
Merged
ahcorde added a commit that referenced this pull request Jun 6, 2024
@mergify @ahcorde
Add test creating two content filter topics with the same topic name (#…
119a7bc 
…2546) (#2549) (#2552)

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
(cherry picked from commit 7c09688)

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
fujitatomoya pushed a commit that referenced this pull request Jun 7, 2024
@mergify @ahcorde
Add test creating two content filter topics with the same topic name (#…
47adc8f 
…2546) (#2549) (#2550)

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
(cherry picked from commit 7c09688)

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
fujitatomoya pushed a commit that referenced this pull request Jun 12, 2024
@mergify @ahcorde
Add test creating two content filter topics with the same topic name (#…
32f1961 
…2546) (#2549) (#2551)

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
(cherry picked from commit 7c09688)

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
bartalor pushed a commit to bartalor/rclcpp that referenced this pull request Jul 15, 2026
@ahcorde @Mario-DL
Add test creating two content filter topics with the same topic name (r…
f06b9de 
…os2#2546) (ros2#2549)

Signed-off-by: Mario-DL <mariodominguez@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes
@clalancette clalancette Awaiting requested review from clalancette
@ivanpauno ivanpauno Awaiting requested review from ivanpauno
@hidmic hidmic Awaiting requested review from hidmic
@wjwwood wjwwood Awaiting requested review from wjwwood

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahcorde @fujitatomoya @Mario-DL