Miri: give the incremental session a chance to finish by RalfJung · Pull Request #160760 · rust-lang/rust

RalfJung · 2026-08-08T14:32:42Z

This helps with rust-lang/miri#5013. Reruns still aren't as fast as I'd like, but using nextest to run libcore tests shows a big difference:

before:
 Nextest run ID 56b7b355-6225-4083-96e3-aeeabbe80523 with nextest profile: default-miri
    Starting 10 tests across 2 binaries (2760 tests skipped)
        PASS [  31.264s] coretests::coretests any::any_downcast_mut
        PASS [  31.287s] coretests::coretests any::distinct_type_names
        PASS [  32.747s] coretests::coretests iter::traits::iterator::test_any
        PASS [  32.758s] coretests::coretests any::any_owning
        PASS [  32.864s] coretests::coretests any::dyn_type_name
        PASS [  32.973s] coretests::coretests any::any_downcast_ref
        PASS [  33.139s] coretests::coretests any::any_unsized
        PASS [  33.719s] coretests::coretests any::any_referenced
        PASS [  35.786s] coretests::coretests any::any_fixed_vec
        PASS [  38.951s] coretests::coretests num::dec2flt::parse::many_digits
────────────
     Summary [  38.955s] 10 tests run: 10 passed, 2760 skipped

after:
 Nextest run ID af603971-e41e-466d-8469-0425057fa325 with nextest profile: default-miri
    Starting 10 tests across 2 binaries (2761 tests skipped)
        PASS [  15.063s] coretests::coretests any::any_unsized
        PASS [  15.176s] coretests::coretests any::distinct_type_names
        PASS [  15.200s] coretests::coretests any::any_referenced
        PASS [  15.550s] coretests::coretests iter::traits::iterator::test_any
        PASS [  15.993s] coretests::coretests any::any_fixed_vec
        PASS [  17.506s] coretests::coretests num::dec2flt::parse::many_digits
        PASS [  17.902s] coretests::coretests any::any_downcast_ref
        PASS [  18.188s] coretests::coretests any::any_owning
        PASS [  19.270s] coretests::coretests any::dyn_type_name
        PASS [  19.702s] coretests::coretests any::any_downcast_mut
────────────
     Summary [  19.705s] 10 tests run: 10 passed, 2761 skipped

It still seems to spend at least 10s building the crate before Miri even begins running, no idea what it is doing in that time. But it's 15s less than before so that's good. :)

RalfJung · 2026-08-08T14:34:18Z

@bors try jobs=dist-x86_64-linux

Miri: give the incremental session a chance to finish try-job: dist-x86_64-linux

RalfJung · 2026-08-08T14:41:13Z

@bors try jobs=dist-x86_64-linux

Miri: give the incremental session a chance to finish try-job: dist-x86_64-linux

rustbot · 2026-08-08T15:38:24Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

miri is developed in its own repository. If the Miri part of this change can be broken out, consider making this change to rust-lang/miri instead. However, if Miri needs adjusting for rustc changes, just ignore this message.

cc @rust-lang/miri

rustbot · 2026-08-08T15:38:26Z

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 19 candidates

RalfJung · 2026-08-08T15:39:21Z

r? @bjorn3

rustbot · 2026-08-08T15:39:24Z

Failed to set assignee to bjorn3: error sending request

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

RalfJung · 2026-08-08T15:41:14Z

           1: main
               at tests/native-lib/pass/ptr_read_access.rs:LL:CC

+warning: 1 warning emitted


It's kind of annoying that we get this output now... but warnings are rare in Miri so 🤷

View changes since the review

RalfJung · 2026-08-08T15:43:26Z

@bors try jobs=dist-x86_64-linux

Miri: give the incremental session a chance to finish try-job: dist-x86_64-linux

bjorn3 · 2026-08-08T15:54:00Z

Failed to set assignee to bjorn3: error sending request

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

Github api hickup I guess.

r? bjorn3

RalfJung · 2026-08-12T10:57:12Z

Oh, it's just a win-host-only test that I cannot bless automatically as I do not have a win host.

rustbot · 2026-08-14T06:42:28Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

RalfJung · 2026-08-14T06:42:57Z

@bors try jobs=x86_64-msvc-ext2

Miri: give the incremental session a chance to finish try-job: x86_64-msvc-ext2

RalfJung · 2026-08-14T06:44:09Z

@bors try jobs=x86_64-msvc-ext2

Miri: give the incremental session a chance to finish try-job: x86_64-msvc-ext2

rust-bors · 2026-08-14T08:35:59Z

☀️ Try build successful (CI)
Build commit: acbb990 (acbb9908e1d894d01828688ff21e405618d4eef3)
Base parent: 93c9086 (93c9086fdd5b80d286480a19ac047746ecc5fa1f)

bjorn3 · 2026-08-14T09:36:22Z

@bors r+

rust-bors · 2026-08-14T09:36:25Z

📌 Commit 9221154 has been approved by bjorn3

It is now in the queue for this repository.

Miri: give the incremental session a chance to finish This helps with rust-lang/miri#5013. Reruns still aren't as fast as I'd like, but using nextest to run libcore tests shows a big difference: ``` before: Nextest run ID 56b7b355-6225-4083-96e3-aeeabbe80523 with nextest profile: default-miri Starting 10 tests across 2 binaries (2760 tests skipped) PASS [ 31.264s] coretests::coretests any::any_downcast_mut PASS [ 31.287s] coretests::coretests any::distinct_type_names PASS [ 32.747s] coretests::coretests iter::traits::iterator::test_any PASS [ 32.758s] coretests::coretests any::any_owning PASS [ 32.864s] coretests::coretests any::dyn_type_name PASS [ 32.973s] coretests::coretests any::any_downcast_ref PASS [ 33.139s] coretests::coretests any::any_unsized PASS [ 33.719s] coretests::coretests any::any_referenced PASS [ 35.786s] coretests::coretests any::any_fixed_vec PASS [ 38.951s] coretests::coretests num::dec2flt::parse::many_digits ──────────── Summary [ 38.955s] 10 tests run: 10 passed, 2760 skipped after: Nextest run ID af603971-e41e-466d-8469-0425057fa325 with nextest profile: default-miri Starting 10 tests across 2 binaries (2761 tests skipped) PASS [ 15.063s] coretests::coretests any::any_unsized PASS [ 15.176s] coretests::coretests any::distinct_type_names PASS [ 15.200s] coretests::coretests any::any_referenced PASS [ 15.550s] coretests::coretests iter::traits::iterator::test_any PASS [ 15.993s] coretests::coretests any::any_fixed_vec PASS [ 17.506s] coretests::coretests num::dec2flt::parse::many_digits PASS [ 17.902s] coretests::coretests any::any_downcast_ref PASS [ 18.188s] coretests::coretests any::any_owning PASS [ 19.270s] coretests::coretests any::dyn_type_name PASS [ 19.702s] coretests::coretests any::any_downcast_mut ──────────── Summary [ 19.705s] 10 tests run: 10 passed, 2761 skipped ``` It still seems to spend at least 10s building the crate before Miri even begins running, no idea what it is doing in that time. But it's 15s less than before so that's good. :)

…uwer Rollup of 11 pull requests Successful merges: - #158510 (Enable `static_position_independent_executables` on all gnu targets) - #160441 (PowerPC inline ASM: Fix scalar floats being in the wrong vector lane on little endian) - #160760 (Miri: give the incremental session a chance to finish) - #160892 (Inline some hot new-solver functions) - #160821 (Updates the expect messages in library/std/src/net/udp.rs to follow the style guide) - #160997 (Add an AGENTS.md that enforces the LLM policy) - #161057 (Silence unecessary errors on `Vec<foo::Bar>` to `Vec<foo:Bar>` typo) - #161079 (bootstrap: Clean up imports related to `define_config!` and `check_ci_llvm!`) - #161080 (propagate `RerunNonErased` in `projection_may_match`) - #161085 (bootstrap: Restrict the normalization of relative paths) - #161086 (add crashtests [3/N])

Rollup merge of #160760 - RalfJung:miri-incremental, r=bjorn3 Miri: give the incremental session a chance to finish This helps with rust-lang/miri#5013. Reruns still aren't as fast as I'd like, but using nextest to run libcore tests shows a big difference: ``` before: Nextest run ID 56b7b355-6225-4083-96e3-aeeabbe80523 with nextest profile: default-miri Starting 10 tests across 2 binaries (2760 tests skipped) PASS [ 31.264s] coretests::coretests any::any_downcast_mut PASS [ 31.287s] coretests::coretests any::distinct_type_names PASS [ 32.747s] coretests::coretests iter::traits::iterator::test_any PASS [ 32.758s] coretests::coretests any::any_owning PASS [ 32.864s] coretests::coretests any::dyn_type_name PASS [ 32.973s] coretests::coretests any::any_downcast_ref PASS [ 33.139s] coretests::coretests any::any_unsized PASS [ 33.719s] coretests::coretests any::any_referenced PASS [ 35.786s] coretests::coretests any::any_fixed_vec PASS [ 38.951s] coretests::coretests num::dec2flt::parse::many_digits ──────────── Summary [ 38.955s] 10 tests run: 10 passed, 2760 skipped after: Nextest run ID af603971-e41e-466d-8469-0425057fa325 with nextest profile: default-miri Starting 10 tests across 2 binaries (2761 tests skipped) PASS [ 15.063s] coretests::coretests any::any_unsized PASS [ 15.176s] coretests::coretests any::distinct_type_names PASS [ 15.200s] coretests::coretests any::any_referenced PASS [ 15.550s] coretests::coretests iter::traits::iterator::test_any PASS [ 15.993s] coretests::coretests any::any_fixed_vec PASS [ 17.506s] coretests::coretests num::dec2flt::parse::many_digits PASS [ 17.902s] coretests::coretests any::any_downcast_ref PASS [ 18.188s] coretests::coretests any::any_owning PASS [ 19.270s] coretests::coretests any::dyn_type_name PASS [ 19.702s] coretests::coretests any::any_downcast_mut ──────────── Summary [ 19.705s] 10 tests run: 10 passed, 2761 skipped ``` It still seems to spend at least 10s building the crate before Miri even begins running, no idea what it is doing in that time. But it's 15s less than before so that's good. :)

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 8, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Aug 8, 2026

Auto merge of #160760 - RalfJung:miri-incremental, r=<try>

43b1433

Miri: give the incremental session a chance to finish try-job: dist-x86_64-linux

RalfJung force-pushed the miri-incremental branch 3 times, most recently from 9e91369 to 271cccb Compare August 8, 2026 14:40

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Aug 8, 2026

Auto merge of #160760 - RalfJung:miri-incremental, r=<try>

3653762

Miri: give the incremental session a chance to finish try-job: dist-x86_64-linux

This comment has been minimized.

Sign in to view

RalfJung force-pushed the miri-incremental branch from 271cccb to 19c9e78 Compare August 8, 2026 15:36

RalfJung marked this pull request as ready for review August 8, 2026 15:38

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 8, 2026

rustbot assigned nnethercote Aug 8, 2026

RalfJung mentioned this pull request Aug 8, 2026

cargo miri nextest run spends a lot of time rebuilding the test crate rust-lang/miri#5013

Open

RalfJung commented Aug 8, 2026

View reviewed changes

Comment thread compiler/rustc_driver_impl/src/lib.rs Outdated

RalfJung commented Aug 8, 2026

View reviewed changes

Comment thread compiler/rustc_driver_impl/Cargo.toml Outdated

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Aug 8, 2026

Auto merge of #160760 - RalfJung:miri-incremental, r=<try>

5b05222

Miri: give the incremental session a chance to finish try-job: dist-x86_64-linux

RalfJung force-pushed the miri-incremental branch from 19c9e78 to 7e4d876 Compare August 8, 2026 15:49

This comment has been minimized.

Sign in to view

RalfJung force-pushed the miri-incremental branch from e8c3f61 to 42823c3 Compare August 14, 2026 06:42

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Aug 14, 2026

Auto merge of #160760 - RalfJung:miri-incremental, r=<try>

068bd44

Miri: give the incremental session a chance to finish try-job: x86_64-msvc-ext2

RalfJung added 2 commits August 14, 2026 08:43

Miri: give the incremental session a chance to finish

48a04ff

fix unused features in Miri tests

9221154

RalfJung force-pushed the miri-incremental branch from 42823c3 to 9221154 Compare August 14, 2026 06:44

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Aug 14, 2026

Auto merge of #160760 - RalfJung:miri-incremental, r=<try>

acbb990

Miri: give the incremental session a chance to finish try-job: x86_64-msvc-ext2

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 14, 2026

JonathanBrouwer mentioned this pull request Aug 14, 2026

Rollup of 10 pull requests #161089

Closed

This was referenced Aug 14, 2026

Rollup of 11 pull requests #161092

Closed

Rollup of 11 pull requests #161093

Merged

rust-bors Bot merged commit 4a07696 into rust-lang:main Aug 14, 2026
14 checks passed

rustbot added this to the 1.99.0 milestone Aug 14, 2026

RalfJung deleted the miri-incremental branch August 15, 2026 06:49

Uh oh!

Uh oh!

Conversation

RalfJung commented Aug 8, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RalfJung commented Aug 8, 2026

Uh oh!

This comment has been minimized.

RalfJung commented Aug 8, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rustbot commented Aug 8, 2026

Uh oh!

rustbot commented Aug 8, 2026

Uh oh!

RalfJung commented Aug 8, 2026

Uh oh!

rustbot commented Aug 8, 2026

Uh oh!

Uh oh!

RalfJung Aug 8, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

RalfJung commented Aug 8, 2026

Uh oh!

This comment has been minimized.

bjorn3 commented Aug 8, 2026

Uh oh!

This comment has been minimized.

RalfJung commented Aug 12, 2026 via email

Uh oh!

This comment has been minimized.

rustbot commented Aug 14, 2026

Uh oh!

RalfJung commented Aug 14, 2026

Uh oh!

This comment has been minimized.

RalfJung commented Aug 14, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Aug 14, 2026

Uh oh!

bjorn3 commented Aug 14, 2026

Uh oh!

rust-bors Bot commented Aug 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

RalfJung commented Aug 8, 2026 •

edited by rustbot

Loading

RalfJung Aug 8, 2026 •

edited by rustbot

Loading