Skip to content

Updates the expect messages in library/std/src/net/udp.rs to follow the style guide - #160821

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
jaroslawroszyk:main
Aug 14, 2026
Merged

Updates the expect messages in library/std/src/net/udp.rs to follow the style guide#160821
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
jaroslawroszyk:main

Conversation

@jaroslawroszyk

@jaroslawroszyk jaroslawroszyk commented Aug 9, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

View all comments

  • I did not use an LLM to create a change in this PR.
  • I used an LLM to create a change in this PR, and I have explained below how it was used.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 9, 2026
@rustbot

rustbot commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

r? @clarfonthey

rustbot has assigned @clarfonthey.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 13 candidates
  • Random selection from JohnTitor, Mark-Simulacrum, clarfonthey, nia-e

@rustbot

This comment has been minimized.

Sign in to view
@jaroslawroszyk jaroslawroszyk changed the title Updates the expect messages in library/std/src/net/udp.rs to follow the style guide. Updates the expect messages in library/std/src/net/udp.rs to follow the style guide. Related issue: #159751 Aug 9, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
clarfonthey
clarfonthey reviewed Aug 9, 2026
View reviewed changes
Comment thread library/std/src/net/udp.rs Outdated
@clarfonthey

clarfonthey commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

CI failure appears spurious. If you fix the commit messages to remove the reference to the issue, and also make the minor change I suggest, this looks good to me. Thank you!

(That is, r=me once those are fixed.)

@rustbot

This comment has been minimized.

Sign in to view
@jaroslawroszyk jaroslawroszyk changed the title Updates the expect messages in library/std/src/net/udp.rs to follow the style guide. Related issue: #159751 Updates the expect messages in library/std/src/net/udp.rs to follow the style guide #159751 Aug 10, 2026
@jaroslawroszyk jaroslawroszyk changed the title Updates the expect messages in library/std/src/net/udp.rs to follow the style guide #159751 Updates the expect messages in library/std/src/net/udp.rs to follow the style guide Aug 10, 2026
@jaroslawroszyk

jaroslawroszyk commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

@clarfonthey
Now commit msg was fixed and also code :D

@clarfonthey

clarfonthey commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

So, the commit linter is specifically saying you shouldn't include issue references at all in the commit message so it avoids spamming in the commits; since the PR description gets included, you can actually keep it there.

@jaroslawroszyk

jaroslawroszyk commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

So, the commit linter is specifically saying you shouldn't include issue references at all in the commit message so it avoids spamming in the commits; since the PR description gets included, you can actually keep it there.

So @clarfonthey we're merging?

@clarfonthey

clarfonthey commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

It still has an issue reference in the commit message, unless github is being weird and not showing the latest one.

@jaroslawroszyk

jaroslawroszyk commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

It still has an issue reference in the commit message, unless github is being weird and not showing the latest one.

in pr title I have:
Updates the expect messages in library/std/src/net/udp.rs to follow the style guide - #160821

and the description:
Related issue: #159751

I did not use an LLM to create a change in this PR.
I used an LLM to create a change in this PR, and I have explained below how it was used.

what should I improve? @clarfonthey

@clarfonthey

clarfonthey commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Ah, are you using the GitHub CLI or some other tool to edit the changes?

Since on the commits tab, it still shows the related issue in the commit message, that's what I'm talking about specifically:
commits tab screenshot

@jaroslawroszyk

jaroslawroszyk commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Ah, are you using the GitHub CLI or some other tool to edit the changes?

Since on the commits tab, it still shows the related issue in the commit message, that's what I'm talking about specifically:

commits tab screenshot

to be sure, there should be no linked issue in the commit title or commit msg?

@clarfonthey

clarfonthey commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Correct, nothing in the commit, the PR description is separate and fine to include that.

@jaroslawroszyk

jaroslawroszyk commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Correct, nothing in the commit, the PR description is separate and fine to include that.

Updated

@jaroslawroszyk

jaroslawroszyk commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

@clarfonthey it will going to merge?

@clarfonthey

clarfonthey commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

…I was waiting for the update, but it never happened.

@jaroslawroszyk jaroslawroszyk changed the title Updates the expect messages in library/std/src/net/udp.rs to follow the style guide Updates the expect messages in library/std/src/net/udp.rs to follow the style guide Closes: #159751 Aug 13, 2026
@jaroslawroszyk

jaroslawroszyk commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

@clarfonthey
Sorry for the confusion! I misread commit message as PR title. I've amended the actual git commit now and force-pushe

@clarfonthey clarfonthey changed the title Updates the expect messages in library/std/src/net/udp.rs to follow the style guide Closes: #159751 Updates the expect messages in library/std/src/net/udp.rs to follow the style guide Aug 13, 2026
@clarfonthey

clarfonthey commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup

Thank you!

@rust-bors

rust-bors Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 1b5cb9f has been approved by clarfonthey

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 14, 2026
@JonathanBrouwer
Rollup merge of rust-lang#160821 - jaroslawroszyk:main, r=clarfonthey
9941d90 
Updates the expect messages in library/std/src/net/udp.rs to follow the style guide

- [x] I did not use an LLM to create a change in this PR.
- [ ] I used an LLM to create a change in this PR, and I have explained below how it was used.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 14, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 14, 2026
@JonathanBrouwer
Rollup merge of rust-lang#160821 - jaroslawroszyk:main, r=clarfonthey
72696ea 
Updates the expect messages in library/std/src/net/udp.rs to follow the style guide

- [x] I did not use an LLM to create a change in this PR.
- [ ] I used an LLM to create a change in this PR, and I have explained below how it was used.
This was referenced Aug 14, 2026
Closed
Merged
rust-bors Bot pushed a commit that referenced this pull request Aug 14, 2026
@bors
Auto merge of #161093 - JonathanBrouwer:rollup-ZAPw9dB, r=JonathanBro…
2fb4ed8 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #158510 (Enable `static_position_independent_executables` on all gnu targets)
 - #160441 (PowerPC inline ASM: Fix scalar floats being in the wrong vector lane on little endian)
 - #160760 (Miri: give the incremental session a chance to finish)
 - #160892 (Inline some hot new-solver functions)
 - #160821 (Updates the expect messages in library/std/src/net/udp.rs to follow the style guide)
 - #160997 (Add an AGENTS.md that enforces the LLM policy)
 - #161057 (Silence unecessary errors on `Vec<foo::Bar>` to `Vec<foo:Bar>` typo)
 - #161079 (bootstrap: Clean up imports related to `define_config!` and `check_ci_llvm!`)
 - #161080 (propagate `RerunNonErased` in `projection_may_match`)
 - #161085 (bootstrap: Restrict the normalization of relative paths)
 - #161086 (add crashtests [3/N])
@rust-bors
rust-bors Bot merged commit 22e565a into rust-lang:main Aug 14, 2026
13 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Aug 14, 2026
rust-bors Bot pushed a commit that referenced this pull request Aug 14, 2026
@bors
Unrolled build for #160821
099ad39 
Rollup merge of #160821 - jaroslawroszyk:main, r=clarfonthey

Updates the expect messages in library/std/src/net/udp.rs to follow the style guide

- [x] I did not use an LLM to create a change in this PR.
- [ ] I used an LLM to create a change in this PR, and I have explained below how it was used.
rust-timer added a commit that referenced this pull request Aug 14, 2026
@rust-timer
Unrolled build for #160821
e0789b4 
Rollup merge of #160821 - jaroslawroszyk:main, r=clarfonthey

Updates the expect messages in library/std/src/net/udp.rs to follow the style guide

- [x] I did not use an LLM to create a change in this PR.
- [ ] I used an LLM to create a change in this PR, and I have explained below how it was used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clarfonthey clarfonthey clarfonthey left review comments

Assignees

@clarfonthey clarfonthey

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jaroslawroszyk @rustbot @rust-log-analyzer @clarfonthey