tests: Run more pauth tests in CI and make them pass by jchlanda · Pull Request #162228 · rust-lang/rust

jchlanda · 2026-09-03T10:16:39Z

Some pauth tests have ended up failing since they were not run in CI.
Make them run and make them pass.

This is a follow up to: #161183

rustbot · 2026-09-03T10:16:44Z

rustbot has assigned @Enselic.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 21 candidates

Enselic · 2026-09-03T18:30:53Z

How come we don't run these tests in CI? Have that been discussed somewhere before?

jchlanda · 2026-09-04T10:50:35Z

How come we don't run these tests in CI? Have that been discussed somewhere before?

No, not discussed yet.

This looks like a bug on my part. Early on when we worked on run-make tests I've added ignore-pauthtest and only-pauthtest. This made sense, since aarch64-unknown-linux-pauthtest requires pointer-authentication-enabled sysroot based on a custom Musl toolchain (not provided by CI). Somehow those directives (mostly only) crept into all the tests.

Let me have a once over for all the tests and see what the CI has to say.

In the meantime I'll turn it to a WIP PR.

jchlanda · 2026-09-08T06:25:06Z

How come we don't run these tests in CI? Have that been discussed somewhere before?

@Enselic this is now ready for review. I've gone over the uses of ignore|only-pauthtest and only keept the directives where they were strictly needed.

I can see the test executing (and passing) in the CI:

incompatible_pauth.rs (that started this PR)
codegen tests

rustbot · 2026-09-17T04:07:57Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Enselic

I think the changes themselves look reasonable now, but I'd like us to adjust the commit title and PR title.

A commit title shall make sense on its own, so "the test" is a bit too vague. What do you think of having a commit and PR title like the following?:

tests: Run more pauth tests in CI and make them pass

And as PR and commit description we can have something like:

Some pauth tests have ended up failing since they were not run in CI.
Make them run and make them pass.

I'd say it is also overly separated to have two commits. Are you OK with putting it all in one commit?

View changes since this review

jchlanda · 2026-09-18T08:56:42Z

Some pauth tests have ended up failing since they were not run in CI.
Make them run and make them pass.

Yes to both, thank you for the suggestion. Squashed commits to just one.

jchlanda · 2026-09-18T08:57:47Z

@rustbot ready

Enselic

This looks good to me now, thanks.

Since the tests will now run in a broader set of circumstances it is reasonable to expect some failures when the full CI test suite is run. Therefore I am marking this as rollup=iffy.

@bors r+ rollup=iffy

View changes since this review

rust-bors · 2026-09-19T16:50:21Z

📌 Commit 03f9117 has been approved by Enselic

It is now in the queue for this repository.

…r=Enselic tests: Run more pauth tests in CI and make them pass Some pauth tests have ended up failing since they were not run in CI. Make them run and make them pass. This is a follow up to: rust-lang#161183

Enselic · 2026-09-23T03:54:29Z

+    type Output = i32;
+
+    fn add(self, other: i32) -> i32 {
+        7


Looks like my local LLVM (top of the tree) was able to perform tail call optimization for this test, while CI's (21?) was not.

That's because the particular CI job that fails runs tests without optimizations:

rust/src/ci/docker/host-x86_64/x86_64-gnu-nopt/Dockerfile

Line 26 in d19a07b

--disable-optimize-tests \

I suggest we do the same thing as many other tests in ./tests/assembly-llvm and set an explicit and fixed -Copt-level to keep emitted assembly fixed. That way we don't have to make strange (on first glance) changes to minicore.

View changes since the review

Right, thank you for the clarification.

I've set the optimisation level and reverted the minicore changes, in favour of using, already defined, Neg.
Kept the uses of function calls as the generated code shows more pointer authentication instructions (pacibsp, retab).

Enselic · 2026-09-23T16:02:58Z

-// CHECK:       mov     x0, [[FN_REG]]
-// CHECK:       b       call_through
+// CHECK:       pacibsp
+// CHECK:       adrp [[GOT_REG:x[0-9]+]], :got:c_func


I don't feel qualified to review emitted aarch64 assembly (or at least it is a significant effort for me), so may I please ask you to change the emitted assembly in a separate PR and only add the opt-level line to my previously approved commit (in the same, single commit)?

It would be nice to get this CI improvement merged before iterating a change on one specific test.

View changes since the review

That's fair. Reverted to just the opt level change.

Some pauth tests have ended up failing since they were not run in CI. Make them run and make them pass.

Enselic

Thanks.

Marking as rollup=iffy again with same motivation as last time.

@bors r+ rollup=iffy

View changes since this review

rust-bors · 2026-09-24T18:04:09Z

📌 Commit 96b181c has been approved by Enselic

It is now in the queue for this repository.

…r=Enselic tests: Run more pauth tests in CI and make them pass Some pauth tests have ended up failing since they were not run in CI. Make them run and make them pass. This is a follow up to: rust-lang#161183

Rollup of 9 pull requests Successful merges: - #162228 (tests: Run more pauth tests in CI and make them pass) - #162493 (Add support for -Zsanitizer-cfi-minimal-runtime) - #163271 (add a leak check test) - #163282 (cleanup: clean up more dependencies that are unused) - #157562 (Avoid computing layout of enums with non-int discriminants) - #162275 (Do not increase recursion depth for coroutine witness and rigid opaques when proving auto traits) - #163037 (fix and test `va_arg` on `f128` on `x86`) - #163114 (Add regression test for hang on mutually recursive trait impls) - #163255 (Check the entire library and cg_clif workspaces for permitted deps in tidy)

Rollup of 8 pull requests Successful merges: - #162228 (tests: Run more pauth tests in CI and make them pass) - #163271 (add a leak check test) - #163282 (cleanup: clean up more dependencies that are unused) - #157562 (Avoid computing layout of enums with non-int discriminants) - #162275 (Do not increase recursion depth for coroutine witness and rigid opaques when proving auto traits) - #163037 (fix and test `va_arg` on `f128` on `x86`) - #163114 (Add regression test for hang on mutually recursive trait impls) - #163255 (Check the entire library and cg_clif workspaces for permitted deps in tidy)

Rollup merge of #162228 - jchlanda:jakub/pac_span_test_fix, r=Enselic tests: Run more pauth tests in CI and make them pass Some pauth tests have ended up failing since they were not run in CI. Make them run and make them pass. This is a follow up to: #161183

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 3, 2026

rustbot assigned Enselic Sep 3, 2026

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 3, 2026

jchlanda force-pushed the jakub/pac_span_test_fix branch from 3dd50a5 to f9688a6 Compare September 3, 2026 10:26

This comment has been minimized.

Sign in to view

jchlanda force-pushed the jakub/pac_span_test_fix branch from 3ce0220 to 4e177fe Compare September 7, 2026 13:55

This comment has been minimized.

Sign in to view

jchlanda force-pushed the jakub/pac_span_test_fix branch from 4e177fe to cd25ff9 Compare September 7, 2026 14:47

Enselic requested changes Sep 17, 2026

View reviewed changes

Comment thread tests/codegen-llvm/pauth/pauth-attr-cli-flags.rs Outdated

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2026

jchlanda force-pushed the jakub/pac_span_test_fix branch from cd25ff9 to 63a674d Compare September 17, 2026 06:29

Enselic requested changes Sep 17, 2026

View reviewed changes

Comment thread tests/ui/statics/crt-static-pauthtest.rs Outdated

jchlanda force-pushed the jakub/pac_span_test_fix branch from 63a674d to 03f9117 Compare September 18, 2026 08:56

jchlanda changed the title ~~Update the test not to expect a span in mixed -Zpointer-authentication~~ tests: Run more pauth tests in CI and make them pass Sep 18, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 18, 2026

Enselic approved these changes Sep 19, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2026

jhpratt mentioned this pull request Sep 19, 2026

Rollup of 6 pull requests #163033

Closed

Enselic requested changes Sep 23, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2026

jchlanda force-pushed the jakub/pac_span_test_fix branch from ab9f9a2 to d91db79 Compare September 23, 2026 07:08

This comment has been minimized.

Sign in to view

jchlanda force-pushed the jakub/pac_span_test_fix branch from d91db79 to 9528bf9 Compare September 23, 2026 07:31

jchlanda requested a review from Enselic September 23, 2026 08:28

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 23, 2026

Enselic requested changes Sep 23, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2026

jchlanda force-pushed the jakub/pac_span_test_fix branch from 9528bf9 to 8a32403 Compare September 24, 2026 12:04

tests: Run more pauth tests in CI and make them pass

96b181c

Some pauth tests have ended up failing since they were not run in CI. Make them run and make them pass.

jchlanda force-pushed the jakub/pac_span_test_fix branch from 8a32403 to 96b181c Compare September 24, 2026 12:07

jchlanda requested a review from Enselic September 24, 2026 12:07

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 24, 2026

Enselic approved these changes Sep 24, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 24, 2026

jhpratt mentioned this pull request Sep 24, 2026

Rollup of 9 pull requests #163287

Closed

jhpratt mentioned this pull request Sep 25, 2026

Rollup of 8 pull requests #163300

Merged

rust-bors Bot merged commit f43cc4d into rust-lang:main Sep 25, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Sep 25, 2026

Uh oh!

Conversation

jchlanda commented Sep 3, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Sep 3, 2026

Uh oh!

Enselic commented Sep 3, 2026

Uh oh!

jchlanda commented Sep 4, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

jchlanda commented Sep 8, 2026

Uh oh!

Uh oh!

rustbot commented Sep 17, 2026

Uh oh!

Enselic left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jchlanda commented Sep 18, 2026

Uh oh!

jchlanda commented Sep 18, 2026

Uh oh!

Enselic left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Sep 19, 2026

Uh oh!

Enselic Sep 23, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jchlanda Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Enselic Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jchlanda Sep 24, 2026

Choose a reason for hiding this comment

Uh oh!

Enselic left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Sep 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jchlanda commented Sep 3, 2026 •

edited by rustbot

Loading

Enselic left a comment •

edited

Loading

Enselic left a comment •

edited

Loading

Enselic Sep 23, 2026 •

edited by rustbot

Loading

jchlanda Sep 23, 2026 •

edited

Loading

Enselic Sep 23, 2026 •

edited

Loading

Enselic left a comment •

edited by rustbot

Loading