Check the entire library and cg_clif workspaces for permitted deps in tidy - #163255
Merged
Merged
Conversation
… tidy We ship the entire library workspace in the rust-src component, so even if the standard library doesn't depend on a crate, having it in the library workspace still increases the amount of storage a rust install takes. And for cg_clif I personally want to keep deps to a minimum even those not for the backend itself.
Collaborator
|
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. cc @davidtwco, @BoxyUwU |
Collaborator
|
r? @clubby789 rustbot has assigned @clubby789. Use Why was this reviewer chosen?The reviewer was selected based on:
|
clubby789
reviewed
Sep 24, 2026
bjorn3
force-pushed
the
stricter_tidy_dep_check
branch
from
September 24, 2026 14:14
85f350d to
773b82c
Compare
bjorn3
force-pushed
the
stricter_tidy_dep_check
branch
from
September 24, 2026 14:23
773b82c to
fc538ec
Compare
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot)Important For more information how to resolve CI failures of this job, visit this link. |
Member
Author
|
GHA hickup, not a genuine failure. |
Contributor
|
@bors r+ rollup |
Contributor
|
❌ Cannot approve commit fc538ec, because CI currently fails on this PR. Use |
Member
Author
|
@bors r=clubby789 force |
Contributor
Member
Author
|
@bors rollup |
Member
(Just noting that the PR attributes are set eagerly, so even if the approval fails because of PR CI, the rollup mode was already set) |
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Sep 24, 2026
…clubby789 Check the entire library and cg_clif workspaces for permitted deps in tidy We ship the entire library workspace in the rust-src component, so even if the standard library doesn't depend on a crate, having it in the library workspace still increases the amount of storage a rust install takes. And for cg_clif I personally want to keep deps to a minimum even those not for the backend itself.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 25, 2026
Rollup of 9 pull requests Successful merges: - #162228 (tests: Run more pauth tests in CI and make them pass) - #162493 (Add support for -Zsanitizer-cfi-minimal-runtime) - #163271 (add a leak check test) - #163282 (cleanup: clean up more dependencies that are unused) - #157562 (Avoid computing layout of enums with non-int discriminants) - #162275 (Do not increase recursion depth for coroutine witness and rigid opaques when proving auto traits) - #163037 (fix and test `va_arg` on `f128` on `x86`) - #163114 (Add regression test for hang on mutually recursive trait impls) - #163255 (Check the entire library and cg_clif workspaces for permitted deps in tidy)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 25, 2026
Rollup of 8 pull requests Successful merges: - #162228 (tests: Run more pauth tests in CI and make them pass) - #163271 (add a leak check test) - #163282 (cleanup: clean up more dependencies that are unused) - #157562 (Avoid computing layout of enums with non-int discriminants) - #162275 (Do not increase recursion depth for coroutine witness and rigid opaques when proving auto traits) - #163037 (fix and test `va_arg` on `f128` on `x86`) - #163114 (Add regression test for hang on mutually recursive trait impls) - #163255 (Check the entire library and cg_clif workspaces for permitted deps in tidy)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 25, 2026
Rollup merge of #163255 - bjorn3:stricter_tidy_dep_check, r=clubby789 Check the entire library and cg_clif workspaces for permitted deps in tidy We ship the entire library workspace in the rust-src component, so even if the standard library doesn't depend on a crate, having it in the library workspace still increases the amount of storage a rust install takes. And for cg_clif I personally want to keep deps to a minimum even those not for the backend itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We ship the entire library workspace in the rust-src component, so even if the standard library doesn't depend on a crate, having it in the library workspace still increases the amount of storage a rust install takes. And for cg_clif I personally want to keep deps to a minimum even those not for the backend itself.