Extract duplicate constraint-error handler in personalities.ts - #602
Merged
Merged
Conversation
Both POST and PATCH routes had identical catch blocks for the personalities_name_key constraint violation. Extract a shared throwUnlessDuplicateName helper and adopt the shared errorMessage() utility instead of inline instanceof checks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
throwUnlessDuplicateNamehelper inpersonalities.tsto deduplicate identical catch blocks in the POST and PATCH routes for handling thepersonalities_name_keyunique constraint violationerrorMessage()utility fromshared/lib/error-message.tsinstead of inlineerror instanceof Error ? error.message : ""checksWhy this is tech debt
Both catch blocks were byte-for-byte identical — any change to the error message or status code had to be made in two places. The inline
instanceofcheck also bypassed the sharederrorMessage()helper that prior tech-debt runs established as the project convention.Next up
The next tech-debt run will address incomplete adoption of the shared
errorMessage()helper inagents.tsandtemplates.ts(backlog item #3).Test plan
pnpm run check— TypeScript type checking passespnpm run test— All 95 unit tests passpnpm run test:e2e— All 160 E2E tests pass (12 pre-existing skips)🤖 Generated with Claude Code