Remove 8 AgentManager passthrough methods from route files - #625
Merged
Conversation
Routes (mcp.ts, feedback.ts) now call the underlying modules (telemetry, persona-reviews, feedback) directly via pool instead of routing through AgentManager. This removes 80 lines of pure delegation from manager.ts and makes the data flow explicit at each call site. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
telemetry,persona-reviews, andfeedbackmodules directly viapoolinstead of routing throughAgentManagerpassthrough methodsmanager.ts:listRecentPersonaReviews,listRecentFeedback,getActivitySummary,getAgentHistory,getFeedbackSummary,listFeedback,listFeedbackByParent,updateFeedbackStatusActivitySummaryResult,AgentHistoryEntry,AgentHistoryResult,FeedbackSummaryResult) from manager.tsgetPersonaReviewpassthrough kept — still used bymcp-handlers.tsThis continues the manager.ts passthrough cleanup series (PRs #598, #602, #608, #615, #622).
What qualifies as tech debt
These methods added indirection without value — each was a one-liner that forwarded to the underlying module. Making route files call the modules directly makes the data flow explicit and reduces the surface area of the AgentManager class.
Next run
The backlog item for next run is: manager.ts
createAgentmethod (~300 lines) could be split into setup-script path vs inert path.Test plan
pnpm run check— type checking passespnpm run test— all unit tests passpnpm run test:e2e— 160/160 E2E tests pass🤖 Generated with Claude Code