Move to enum Kernels instead of Structs for hypertuning

[montanalow]

SVCSearchParameters currently uses a Vec for kernels, which means you can't search across multiple kernel types at the same time. This PR converts K to an enum Kernel type, instead of a generic type, so that multiple kinds of kernels may be compared in the same grid search.

[montanalow]

This is a breaking change, so may require more thought on the approach.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 85.89744% with 11 lines in your changes missing coverage. Please review.

Project coverage is 84.51%. Comparing base (764309e) to head (cca8b8f).
Report is 88 commits behind head on development.

Files with missing lines	Patch %	Lines
src/svm/svc.rs	87.50%	5 Missing ⚠️
src/svm/mod.rs	84.00%	4 Missing ⚠️
src/svm/svr.rs	84.61%	2 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           development     #169      +/-   ##
===============================================
+ Coverage        84.47%   84.51%   +0.03%     
===============================================
  Files               86       86              
  Lines             9940     9946       +6     
===============================================
+ Hits              8397     8406       +9     
+ Misses            1543     1540       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Mec-iS]

please add the breaking change to the CHANGESLOG

[morenol]

I think that having the Kernel trait give us more flexibility. More people could implement their own Kernel and use it without troubles. I think that what we could do for ease of use is to convert Kernels into an enum and implement Kernel for Kernels.

I tried that approach in #181

Let me know if that is enough for your use case @montanalow

On the other hand, it looks like the original test is failing. Can you check that in your branch?
I got:

thread 'model_selection::hyper_tuning::tests::svm_check' panicked at 'index out of bounds: the len is 0 but the index is 0', src/svm/svc.rs:724:28

[Mec-iS]

Please adapt these changes to the new code in development.

Kernel is now an object-safe trait. Making an enum of Kernels had been a problem for me because a match expression needs to return the same type. I tried different options but for sure there is something I am missing:

pun enum Kernels {
    Linear(LinearKernel),
    RBF(RBFKernel)
    ...
}

match kernel {
    Linear => LinearKernel::default(),  // this returns a LinearKernel type
    RBF => RBFkernel::default(),       // this returns a RBFKernel type
    ...
}