Conversation
morenol
force-pushed
the
lmm/kernels_enum
branch
from
October 1, 2022 23:26
7df774d to
a753248
Compare
morenol
force-pushed
the
lmm/kernels_enum
branch
from
October 2, 2022 00:00
c96821d to
a753248
Compare
morenol
force-pushed
the
lmm/kernels_enum
branch
from
October 2, 2022 14:02
7b7dedf to
5e9be36
Compare
Codecov Report
@@ Coverage Diff @@
## development #181 +/- ##
===============================================
+ Coverage 84.58% 84.69% +0.10%
===============================================
Files 86 86
Lines 9974 9998 +24
===============================================
+ Hits 8437 8468 +31
+ Misses 1537 1530 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Collaborator
|
@morenol is this still a draft? |
Collaborator
|
|
Mec-iS
requested changes
Oct 31, 2022
Mec-iS
left a comment
Collaborator
There was a problem hiding this comment.
Please resolve conflict with new code in development
Collaborator
Author
|
I think that now that Kernel trait is object safe we can just use #228 approach instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Checklist
Current behaviour
New expected behaviour
Change logs