Handle kernel serialization - #232
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #232 +/- ##
===============================================
+ Coverage 43.97% 44.15% +0.17%
===============================================
Files 85 85
Lines 7281 7275 -6
===============================================
+ Hits 3202 3212 +10
+ Misses 4079 4063 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Wow, typetag is not usable in wasm, I disabled that for WASM32 target. So we have full serialization/deserialization support in all targets except WASM |
|
that is why I wanted default to be empty feature: please add some tests for Kernel serialisation/deserialisation |
Addressed. I agree. I think that by default we should not enable any feature |
I think that there could be a couple of use cases in wasm where deserialization could be useful, but I think that is ok for now to partially support WASM |
yes something we can add later or leave it to the implementation in JS |
|
@morenol please double check that these changes are inline with the new features setup. |
* Handle kernel serialization * Do not use typetag in WASM * enable tests for serialization * Update serde feature deps Co-authored-by: Luis Moreno <morenol@users.noreply.github.com> Co-authored-by: Lorenzo <tunedconsulting@gmail.com>
Fixes #221
Checklist
Current behaviour
New expected behaviour