Skip to content

Handle kernel serialization - #232

Merged
Mec-iS merged 6 commits into
smartcorelib:developmentfrom
morenol:lmm/kernel_serialization
Nov 8, 2022
Merged

Mec-iS merged 6 commits into
smartcorelib:developmentfrom
morenol:lmm/kernel_serialization

Conversation

@morenol

@morenol morenol commented Nov 4, 2022

Copy link
Copy Markdown
Collaborator

Fixes #221

Checklist

  • My branch is up-to-date with development branch.
  • Everything works and tested on latest stable Rust.
  • Coverage and Linting have been applied

Current behaviour

New expected behaviour

@codecov-commenter

codecov-commenter commented Nov 4, 2022 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.15%. Comparing base (9eaae9e) to head (f883525).
⚠️ Report is 55 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #232      +/-   ##
===============================================
+ Coverage        43.97%   44.15%   +0.17%     
===============================================
  Files               85       85              
  Lines             7281     7275       -6     
===============================================
+ Hits              3202     3212      +10     
+ Misses            4079     4063      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@morenol

morenol commented Nov 4, 2022 •

Copy link
Copy Markdown
Collaborator Author

Wow, typetag is not usable in wasm, I disabled that for WASM32 target. So we have full serialization/deserialization support in all targets except WASM

mmastrac/linktime#14

@morenol
morenol marked this pull request as ready for review November 5, 2022 00:01
@morenol
morenol requested a review from Mec-iS as a code owner November 5, 2022 00:01
@Mec-iS

Mec-iS commented Nov 5, 2022

Copy link
Copy Markdown
Collaborator

that is why I wanted default to be empty feature:
default = []
so that it could compiled to Wasm, we can assume that for in-browser application serialisation is not needed in the Wasm binary.

please add some tests for Kernel serialisation/deserialisation

@morenol

morenol commented Nov 5, 2022

Copy link
Copy Markdown
Collaborator Author

that is why I wanted default to be empty feature: default = [] so that it could compiled to Wasm, we can assume that for in-browser application serialisation is not needed in the Wasm binary.

please add some tests for Kernel serialisation/deserialisation

Addressed.

I agree. I think that by default we should not enable any feature

@morenol

morenol commented Nov 5, 2022

Copy link
Copy Markdown
Collaborator Author

so that it could compiled to Wasm, we can assume that for in-browser application serialisation is not needed in the Wasm binary.

I think that there could be a couple of use cases in wasm where deserialization could be useful, but I think that is ok for now to partially support WASM

@Mec-iS

Mec-iS commented Nov 5, 2022

Copy link
Copy Markdown
Collaborator

I think that there could be a couple of use cases in wasm where deserialization could be useful, but I think that is ok for now to partially support WASM

yes something we can add later or leave it to the implementation in JS

@morenol morenol mentioned this pull request Nov 8, 2022
@Mec-iS

Mec-iS commented Nov 8, 2022

Copy link
Copy Markdown
Collaborator

@morenol please double check that these changes are inline with the new features setup.

@Mec-iS
Mec-iS merged commit 8efb959 into smartcorelib:development Nov 8, 2022
@morenol
morenol deleted the lmm/kernel_serialization branch November 8, 2022 16:18
morenol added a commit that referenced this pull request Nov 8, 2022
* Handle kernel serialization
* Do not use typetag in WASM
* enable tests for serialization
* Update serde feature deps

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
Co-authored-by: Lorenzo <tunedconsulting@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deserialization for Kernel

3 participants