Ready for Release 0.3.0 by Mec-iS · Pull Request #236 · smartcorelib/smartcore

Mec-iS · 2022-11-08T15:25:53Z

merge to main

* build(deps): update nalgebra requirement from 0.23.0 to 0.26.2 Updates the requirements on [nalgebra](https://github.com/dimforge/nalgebra) to permit the latest version. - [Release notes](https://github.com/dimforge/nalgebra/releases) - [Changelog](https://github.com/dimforge/nalgebra/blob/dev/CHANGELOG.md) - [Commits](dimforge/nalgebra@v0.23.0...v0.26.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * fix: updates for nalgebre * test: explicitly call pow_mut from BaseVector since now it conflicts with nalgebra implementation * Don't be strict with dependencies Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

Updates the requirements on [nalgebra](https://github.com/dimforge/nalgebra) to permit the latest version. - [Release notes](https://github.com/dimforge/nalgebra/releases) - [Changelog](https://github.com/dimforge/nalgebra/blob/dev/CHANGELOG.md) - [Commits](dimforge/nalgebra@v0.23.0...v0.31.0) --- updated-dependencies: - dependency-name: nalgebra dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

* initial fastpair implementation * FastPair initial implementation * implement fastpair * Add random test * Add bench for fastpair * Refactor with constructor for FastPair * Add serialization for PairwiseDistance * Add fp_bench feature for fastpair bench

* Add example * Move to top * Add imports to example * Fix imports

* docs: Fix typo in doc for categorical transformer. * feat: Add option to take a column from Matrix. I created the method `Matrix::take_column` that uses the `Matrix::take`-interface to extract a single column from a matrix. I need that feature in the implementation of `StandardScaler`. * feat: Add `StandardScaler`. Authored-by: titoeb <timtoebrock@googlemail.com>

* Derive `serde::Serialize` and `serde::Deserialize` for `StandardScaler`. * Add relevant unit test. Signed-off-by: Christos Katsakioris <ckatsak@gmail.com> Signed-off-by: Christos Katsakioris <ckatsak@gmail.com>

* Update criterion requirement from 0.3 to 0.4 Updates the requirements on [criterion](https://github.com/bheisler/criterion.rs) to permit the latest version. - [Release notes](https://github.com/bheisler/criterion.rs/releases) - [Changelog](https://github.com/bheisler/criterion.rs/blob/master/CHANGELOG.md) - [Commits](bheisler/criterion.rs@0.3.0...0.4.0) --- updated-dependencies: - dependency-name: criterion dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * fix criterion Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

* handle multiclass precision/recall

* grid search draft * hyperparam search for linear estimators

* feat: Add interface to build `Matrix` from rows. * feat: Add option to derive `RealNumber` from string. To construct a `Matrix` from csv, and therefore from string, I need to be able to deserialize a generic `RealNumber` from string. * feat: Implement `Matrix::read_csv`.

…#160) * fix: fix compilation warnings when running only with default features Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

#159) * feat: allocate first and then proceed to create matrix from Vec of RowVectors

* grid search draft * hyperparam search for linear estimators * grid search for ensembles * support grid search for more algos * grid search for unsupervised algos * minor cleanup

* Provide better output in flaky tests * feat: add seed parameter to multiple algorithms * Update changelog Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

* add seed param to search params * make default params available to serde * lints * create defaults for enums * lint

* feat: expose hyper tuning module in model_selection * Move to a folder Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

…release-0.3

morenol · 2022-11-08T15:27:26Z

@Mec-iS I think that we should fix some issues with getrandom in wasm32 when we want to target non-browser targets

Mec-iS · 2022-11-08T15:27:54Z

ok. which issues, please be specific.

morenol · 2022-11-08T15:29:15Z

cargo build --target wasm32-unknown-unknown should compile with success without the need to enable the js (for non browser targets) and use js for browser targets. I think that we should keep using rand instead of getrandom

morenol · 2022-11-08T15:31:46Z

Also, should we merge #232 before release?

* Fixes for release * add new test * Remove change applied in development branch * Only add dependency for wasm32 * Update ci.yml Co-authored-by: Luis Moreno <morenol@users.noreply.github.com> Co-authored-by: Lorenzo <tunedconsulting@gmail.com>

morenol

LGTM, thanks for leading all the effort to accomplish this. Other than maybe merging this first, #232 it looks good to me

Mec-iS · 2022-11-08T16:14:15Z

thanks to you. we merge 232 first

codecov-commenter · 2022-11-08T16:17:01Z

Codecov Report

Merging #236 (9eaae9e) into main (70df9a8) will decrease coverage by 39.44%.
The diff coverage is 48.46%.

@@             Coverage Diff             @@
##             main     #236       +/-   ##
===========================================
- Coverage   83.42%   43.97%   -39.45%     
===========================================
  Files          78       85        +7     
  Lines        8362     7281     -1081     
===========================================
- Hits         6976     3202     -3774     
- Misses       1386     4079     +2693

Impacted Files	Coverage Δ
src/algorithm/neighbour/mod.rs	`46.66% <0.00%> (-31.91%)`	⬇️
src/algorithm/sort/heap_select.rs	`42.85% <ø> (-54.88%)`	⬇️
src/algorithm/sort/quick_sort.rs	`58.10% <ø> (-27.08%)`	⬇️
src/dataset/boston.rs	`83.33% <ø> (-10.00%)`	⬇️
src/dataset/digits.rs	`83.33% <ø> (-8.98%)`	⬇️
src/dataset/mod.rs	`32.14% <0.00%> (-38.23%)`	⬇️
src/error/mod.rs	`33.33% <0.00%> (-14.67%)`	⬇️
src/linalg/traits/high_order.rs	`0.00% <ø> (ø)`
src/metrics/accuracy.rs	`46.15% <ø> (-37.18%)`	⬇️
src/metrics/auc.rs	`50.00% <ø> (-44.74%)`	⬇️
... and 144 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

* Handle kernel serialization * Do not use typetag in WASM * enable tests for serialization * Update serde feature deps Co-authored-by: Luis Moreno <morenol@users.noreply.github.com> Co-authored-by: Lorenzo <tunedconsulting@gmail.com>

morenol · 2022-11-08T16:23:06Z

Not sure if we should squash and merge this, maybe rebase directly into that branch?

Mec-iS · 2022-11-08T16:27:35Z

ok, add the approval and proceed to the merge as you see fit.

dependabot-preview Bot and others added 30 commits May 11, 2022 13:04

Add SVC::decision_function (#135)

b4a807e

Fix clippy warnings (#139)

b482acd

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

Added additional doctest and fixed indices (#141)

d905ebe

Implement fastpair (#142)

a1c56a8

* initial fastpair implementation * FastPair initial implementation * implement fastpair * Add random test * Add bench for fastpair * Refactor with constructor for FastPair * Add serialization for PairwiseDistance * Add fp_bench feature for fastpair bench

Add example for FastPair (#144)

3d2f4f7

* Add example * Move to top * Add imports to example * Fix imports

Add serde for StandardScaler (#148)

4d5f64c

* Derive `serde::Serialize` and `serde::Deserialize` for `StandardScaler`. * Add relevant unit test. Signed-off-by: Christos Katsakioris <ckatsak@gmail.com> Signed-off-by: Christos Katsakioris <ckatsak@gmail.com>

Handle multiclass precision/recall (#152)

2e5f88f

* handle multiclass precision/recall

grid search (#154)

4685fc7

* grid search draft * hyperparam search for linear estimators

fix: fix compilation warnings when running only with default features (…

2510ca4

…#160) * fix: fix compilation warnings when running only with default features Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

Update LICENSE

436da10

Make rand_distr optional (#161)

6a2e104

feat: allocate first and then proceed to create matrix from Vec of Ro… (

c21e752

#159) * feat: allocate first and then proceed to create matrix from Vec of RowVectors

Provide better output in flaky tests (#163)

69d8be3

Complete grid search params (#166)

48514d1

* grid search draft * hyperparam search for linear estimators * grid search for ensembles * support grid search for more algos * grid search for unsupervised algos * minor cleanup

Lmm/add seeds in more algorithms (#164)

3a44161

* Provide better output in flaky tests * feat: add seed parameter to multiple algorithms * Update changelog Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

add seed param to search params (#168)

403d3f2

make default params available to serde (#167)

764309e

* add seed param to search params * make default params available to serde * lints * create defaults for enums * lint

Add contribution guidelines (#178)

0b619fe

Update CONTRIBUTING.md

9c59e37

feat: expose hyper tuning module in model_selection (#179)

3c62686

* feat: expose hyper tuning module in model_selection * Move to a folder Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

refactor: Try to follow similar pattern to other APIs (#180)

f8210d0

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

fix: fix issue with iterator for svc search (#182)

12df301

Update CONTRIBUTING.md

b823b55

Update README.md

8a2bdd5

Update README.md

edbac7e

Mec-iS added 12 commits November 8, 2022 12:17

minor fix

78bf75b

minor fix

b71c7b4

minor fix

a4097fc

minor fixes to doc

6c6f926

Merge branch 'release-0.3' of github.com:smartcorelib/smartcore into …

2418b24

…release-0.3

Remove unused tests flags

98b18c4

Update CHANGELOG

dad0d01

use getrandom/js

48f1d6b

update comment

c934f6b

update CHANGELOG

6c03e6e

Merge branch 'release-0.3' of github.com:smartcorelib/smartcore into …

4558be5

…release-0.3

Release 0.3 (#235)

161d249

Mec-iS added 2 commits November 8, 2022 15:35

make work cargo build --target wasm32-unknown-unknown

c683073

Merge release-0.3

46b6285

Mec-iS requested a review from morenol November 8, 2022 15:45

morenol reviewed Nov 8, 2022

View reviewed changes

Comment thread Cargo.toml Outdated

Fixes for release (#237)

9eaae9e

* Fixes for release * add new test * Remove change applied in development branch * Only add dependency for wasm32 * Update ci.yml Co-authored-by: Luis Moreno <morenol@users.noreply.github.com> Co-authored-by: Lorenzo <tunedconsulting@gmail.com>

morenol previously approved these changes Nov 8, 2022

View reviewed changes

Handle kernel serialization (#232)

8efb959

* Handle kernel serialization * Do not use typetag in WASM * enable tests for serialization * Update serde feature deps Co-authored-by: Luis Moreno <morenol@users.noreply.github.com> Co-authored-by: Lorenzo <tunedconsulting@gmail.com>

Mec-iS dismissed morenol’s stale review via 8efb959 November 8, 2022 16:18

morenol approved these changes Nov 8, 2022

View reviewed changes

morenol merged commit 62de25b into main Nov 8, 2022

Navigation Menu

Uh oh!

Ready for Release 0.3.0 - #236

Ready for Release 0.3.0#236
morenol merged 81 commits into
mainfrom
development

Mec-iS commented Nov 8, 2022 •

edited

Loading

Uh oh!

morenol commented Nov 8, 2022

Uh oh!

Mec-iS commented Nov 8, 2022 •

edited

Loading

Uh oh!

morenol commented Nov 8, 2022 •

edited

Loading

Uh oh!

morenol commented Nov 8, 2022

Uh oh!

Uh oh!

morenol left a comment

Uh oh!

Mec-iS commented Nov 8, 2022 •

edited

Loading

Uh oh!

codecov-commenter commented Nov 8, 2022

Uh oh!

morenol commented Nov 8, 2022 •

edited

Loading

Uh oh!

Mec-iS commented Nov 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

Mec-iS commented Nov 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

morenol commented Nov 8, 2022

Uh oh!

Mec-iS commented Nov 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

morenol commented Nov 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

morenol commented Nov 8, 2022

Uh oh!

Uh oh!

morenol left a comment

Choose a reason for hiding this comment

Uh oh!

Mec-iS commented Nov 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Nov 8, 2022

Codecov Report

Uh oh!

morenol commented Nov 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mec-iS commented Nov 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Mec-iS commented Nov 8, 2022 •

edited

Loading

Mec-iS commented Nov 8, 2022 •

edited

Loading

morenol commented Nov 8, 2022 •

edited

Loading

Mec-iS commented Nov 8, 2022 •

edited

Loading

morenol commented Nov 8, 2022 •

edited

Loading