Skip to content

refactor: use AutoTestLintOffsets in remaining AnalysisRuleTest suites#311

Open
solid-illiaaihistov wants to merge 2 commits into
solid-software:analysis_server_migrationfrom
solid-illiaaihistov:306-use-auto-test-lint-offsets
Open

refactor: use AutoTestLintOffsets in remaining AnalysisRuleTest suites#311
solid-illiaaihistov wants to merge 2 commits into
solid-software:analysis_server_migrationfrom
solid-illiaaihistov:306-use-auto-test-lint-offsets

Conversation

@solid-illiaaihistov

Copy link
Copy Markdown
Collaborator

Closes #306

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request registers several new lint rules in the plugin, including AvoidUnnecessaryReturnVariableRule, AvoidUnnecessarySetStateRule, AvoidUnrelatedTypeAssertionsRule, NewlineBeforeReturnRule, NoEqualThenElseRule, and PreferEarlyReturnRule. Additionally, it refactors the test suite to utilize the AutoTestLintOffsets utility, replacing hardcoded character offsets with expectLint placeholders for cleaner and more maintainable test assertions. I have no feedback to provide as there are no review comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant