Upgrade project to Go 1.27 - #6639
Merged
Merged
Conversation
JAORMX
requested review from
ChrisJBurns,
amirejaz,
aponcedeleonch,
blkt,
jerm-dro,
jhrozek,
rdimitrov,
reyortiz3 and
tgrunnagle
as code owners
September 11, 2026 07:15
rdimitrov
previously approved these changes
Sep 11, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6639 +/- ##
==========================================
+ Coverage 78.92% 78.96% +0.04%
==========================================
Files 781 782 +1
Lines 77881 78008 +127
==========================================
+ Hits 61467 61600 +133
+ Misses 16409 16403 -6
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rdimitrov
approved these changes
Sep 11, 2026
Merged
5 tasks
3 tasks
reyortiz3
pushed a commit
that referenced
this pull request
Sep 11, 2026
Two leftovers from #6639. The workflow installs Go from sdk/go/go.mod (1.26.0), but sdk-verify runs generator tooling out of the root module, which now needs 1.27. setup-go pins GOTOOLCHAIN=local, so that fails outright instead of upgrading: go: go.mod requires go >= 1.27 (running go 1.26.0; GOTOOLCHAIN=local) Point setup-go at the root go.mod. The SDK module keeps its own lower floor, so this doesn't raise the minimum for SDK consumers. The committed SDK artifacts were also left stale: the bump edited a BuilderImage doc comment ("golang:1.26-alpine" -> "golang:1.27-alpine") which flows through swagger.json into openapi.json/yaml and the generated client, so verify's diff fails even on a correct toolchain. Regenerated with task sdk-generate.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go://builder default, default-image coverage, and affected developer/API documentation.Type of change
Test plan
Unit tests (
task test)E2E tests (
task test-e2e)Linting (
task lint-fix)Manual testing (describe below)
task docscompleted and regenerated the expected OpenAPI documentation.task buildcompleted successfully.task testreached its test command but the locally installedgotestfmt v2.5.0panicked under Go 1.27 (BUG: Empty package name encountered); CI should validate with its clean tool setup.Changes
go.mod,.github/workflows/lint.yml,.claude/rules/go-style.mdpkg/container/templates/*,pkg/runner/protocol_test.gogo://builder image and cover it.docs/.github/workflows/security-scan.ymlDoes this introduce a user-facing change?
Yes.
go://workloads now usegolang:1.27-alpineas their default builder image.Special notes for reviewers
The local
gotestfmtbinary must be updated beforetask testcan run under Go 1.27. The project source generated successfully andtask buildpassed.