fix(sdk): unbreak sdk-verify after the Go 1.27 bump - #6645
Merged
Merged
Conversation
Two leftovers from stacklok#6639. The workflow installs Go from sdk/go/go.mod (1.26.0), but sdk-verify runs generator tooling out of the root module, which now needs 1.27. setup-go pins GOTOOLCHAIN=local, so that fails outright instead of upgrading: go: go.mod requires go >= 1.27 (running go 1.26.0; GOTOOLCHAIN=local) Point setup-go at the root go.mod. The SDK module keeps its own lower floor, so this doesn't raise the minimum for SDK consumers. The committed SDK artifacts were also left stale: the bump edited a BuilderImage doc comment ("golang:1.26-alpine" -> "golang:1.27-alpine") which flows through swagger.json into openapi.json/yaml and the generated client, so verify's diff fails even on a correct toolchain. Regenerated with task sdk-generate.
Merged
5 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6645 +/- ##
==========================================
- Coverage 78.92% 78.91% -0.01%
==========================================
Files 782 782
Lines 78053 78053
==========================================
- Hits 61601 61599 -2
- Misses 16447 16449 +2
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
reyortiz3
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Go SDK / Verify generated Go SDKis red onmain(7e52ab9). Two leftovers from the Go 1.27 bump in #6639.1. The job installs the wrong Go.
setup-goreadssdk/go/go.mod(go 1.26.0), butsdk-verifyruns generator tooling out of the root module (cmd/help/openapi-normalize,cmd/help/ogen-client-wrapper), which is nowgo 1.27.setup-gopinsGOTOOLCHAIN=local, so it fails outright rather than upgrading:Pointed
setup-goat the rootgo.mod. Deliberately not bumpingsdk/go/go.mod- that's the published floor for SDK consumers, and there's no reason to raise it just so CI can run root tooling. Building the 1.26-floor SDK module with a 1.27 toolchain is fine, andsdk-test/sdk-lintstill pass.2. The committed SDK artifacts are stale. The bump also edited a
BuilderImagedoc comment ("golang:1.26-alpine"->"golang:1.27-alpine"), which flows throughdocs/server/swagger.jsonintosdk/go/openapi.json,openapi.yamland the generated client. So even on a correct toolchain, verify's diff fails:Regenerated with
task sdk-generate. It's a one-line change in each of the three files.Type of change
Test plan
task test)task lint-fix)Reproduced both on a clean checkout of main. Under Go 1.26 you get the toolchain error; under 1.27 you get the diff. With this change, on Go 1.27:
I can't exercise the workflow's
setup-gostep locally, so that half is reasoned from the error rather than executed - worth a sanity check from someone who can re-run the job.Does this introduce a user-facing change?
No.
sdk/go/go.modis untouched, so the SDK's minimum Go version for consumers is unchanged.