Skip to content

fix(dsh): stop long-thought scroll layout oscillation - #89

Merged
starsstreaming merged 1 commit into
codex/issue-86-gallery-preferencesfrom
codex/issue-87-scroll-layout
Oct 6, 2026
Merged

starsstreaming merged 1 commit into
codex/issue-86-gallery-preferencesfrom
codex/issue-87-scroll-layout

Conversation

@starsstreaming

@starsstreaming starsstreaming commented Oct 5, 2026 •

Copy link
Copy Markdown
Owner

DSH 的渐隐类附着在原生滚动内容 body 上。背景插件将所有 _fade 类元素设为 display:none,使 ResizeObserver 反复观察到可见高度和零高度;已完成长思考展开后也会持续抖动。

删除普通背景和画窗中的两处隐藏规则,保留宿主内容布局及渐隐 mask。新增浏览器回归验证两种背景模式下的高度、滚动位置与 mask,并删除要求错误隐藏行为的旧断言。

Closes #87

验证:实际脚本的 Edge 浏览器与插件测试共 22 项通过,无失败或跳过。Desktop 0.2.0-rc.2 中同一已完成长思考在修复后连续 180 帧稳定为 400px;恢复旧规则会再次出现隐藏/显示循环。未执行新请求流式或长期压力测试。

依赖 PR #88 的测试夹具;本 PR 只提交滚动布局修复,正式 npm 1.0.29 已包含此修复,发布证据另行提交。

GitHub CI 已完成,但未全绿:Linux 安装 Windows 专用 workspace 报 EBADPLATFORM;Windows 的快捷方式现场测试失败。这些故障同样出现在未改动的 main 基线 CI run 37138973708,本次未改动对应代码。最终源码树本地完整测试 397 项通过、1 项既有跳过,类型检查通过;独立审查无阻塞项。

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dee23ae4-91b3-41c2-b00d-540409859621

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e1eda99005

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +213 to +214
/* Preserve DSH's native fading scroll bodies; hiding them causes the
ResizeObserver to alternate content between visible and zero height (#87). */

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve suppression for the conversation-list fade

When an ordinary or gallery background is active, removing this rule also restores DSH's decorative conversation-list bottom fade, which docs/deepseek-harness.md:87 explicitly says is disabled because it renders a dark band over the wallpaper. The repository-wide search finds no replacement suppression, so fixing the reasoning-body oscillation by deleting the broad selector regresses every wallpaper view containing that list; retain a narrower rule targeting the decorative fade while excluding the [data-step-process-body] scroll content.

Useful? React with 👍 / 👎.

@starsstreaming
starsstreaming merged commit b2190ce into codex/issue-86-gallery-preferences Oct 6, 2026
1 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant