Skip to content

chore: unify language - #858

Merged
manuel3108 merged 10 commits into
mainfrom
test-api
Jan 1, 2026
Merged

chore: unify language#858
manuel3108 merged 10 commits into
mainfrom
test-api

Conversation

@jycouet

@jycouet jycouet commented Dec 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • typescript langTs ext... All expressing the same thing. Let's use ext all the time?
  • ensureScript in parseSvelte directly ?

@changeset-bot

changeset-bot Bot commented Dec 21, 2025 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b764e5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Dec 21, 2025 •
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@858

npx https://pkg.pr.new/sveltejs/cli/sv@858

commit: b764e5b

@svelte-docs-bot

svelte-docs-bot Bot commented Dec 21, 2025

Copy link
Copy Markdown

Preview: https://svelte-dev-git-preview-cli-858-svelte.vercel.app/

manuel3108
manuel3108 requested changes Dec 28, 2025
View reviewed changes
Comment thread packages/sv/lib/cli/add/workspace.ts Outdated
Comment thread packages/sv/lib/addons/_tests/mdsvex/test.ts Outdated
@manuel3108 manuel3108 mentioned this pull request Dec 30, 2025
Merged
@jycouet jycouet changed the title internal - parseSvelte & ensureScript chore: unify language Dec 30, 2025
@manuel3108

manuel3108 commented Dec 30, 2025

Copy link
Copy Markdown
Member

#869 should fix the ci failures here

manuel3108
manuel3108 approved these changes Dec 30, 2025
View reviewed changes

@manuel3108 manuel3108 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from the failing tests and the linked pr

@manuel3108
manuel3108 merged commit 0e09bdd into main Jan 1, 2026
8 checks passed
@manuel3108
manuel3108 deleted the test-api branch January 1, 2026 08:30
@jycouet

jycouet commented Jan 1, 2026

Copy link
Copy Markdown
Contributor Author

Yeahhh ☺️🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuel3108 manuel3108 manuel3108 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jycouet @manuel3108