Skip to content

chore: better ensure script - #867

Merged
jycouet merged 3 commits into
mainfrom
chore/better-ensure-script
Dec 30, 2025
Merged

chore: better ensure script#867
jycouet merged 3 commits into
mainfrom
chore/better-ensure-script

Conversation

@manuel3108

Copy link
Copy Markdown
Member

Continuation of this discussion: #858 (comment)
This should be a pretty good intermediate setup. According to AI we could also include that in parseSvelte as a param, as long as we always use a literal directly (true | false) and do not use a variable. That shouldn't be a problem in our case.

But as that part of the code is being touched by #684 already, I don't want to touch the same code here.

@changeset-bot

changeset-bot Bot commented Dec 30, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: feca29c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Dec 30, 2025

Copy link
Copy Markdown

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@867
npx https://pkg.pr.new/sveltejs/cli/sv@867

commit: feca29c

@manuel3108 manuel3108 mentioned this pull request Dec 30, 2025

@jycouet jycouet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this one a lot

@jycouet
jycouet merged commit efd13cc into main Dec 30, 2025
8 checks passed
@jycouet
jycouet deleted the chore/better-ensure-script branch December 30, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants