Skip to content

[security]: automatically add nonce or hash to script-src-elem, style-src-attr & style-src-elem csp directive if necessary - #11485

Merged
Rich-Harris merged 10 commits into
sveltejs:mainfrom
MathiasWP:main
Jan 8, 2024
Merged

Conversation

@MathiasWP

@MathiasWP MathiasWP commented Dec 29, 2023

Copy link
Copy Markdown
Contributor

This PR adds functionality for automatically adding CSP-directives that are required only if they're used:

  • script-src-elem
  • style-src-attr
  • style-src-elem

error thrown because of missing nonce/hash when script-src-elem is used:

Screenshot 2023-12-30 at 00 21 56

error thrown because of missing nonce/hash if style-src-attr and/or style-src-elem is used:

Screenshot 2023-12-30 at 00 41 47

style-src-attr and style-src-elem is also automatically added during dev so things work locally.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot

changeset-bot Bot commented Dec 29, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1d961f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MathiasWP MathiasWP changed the title add nonce to script-src-elem csp directive if defined automatically add nonce to script-src-elem csp directive if necessary Dec 29, 2023
@MathiasWP MathiasWP changed the title automatically add nonce to script-src-elem csp directive if necessary automatically add nonce or hash to script-src-elem (and style-src-attr & style-src-elem during dev) csp directive if necessary Dec 29, 2023
@MathiasWP MathiasWP changed the title automatically add nonce or hash to script-src-elem (and style-src-attr & style-src-elem during dev) csp directive if necessary automatically add nonce or hash to script-src-elem, style-src-attr & style-src-elem csp directive if necessary Dec 29, 2023
@MathiasWP MathiasWP changed the title automatically add nonce or hash to script-src-elem, style-src-attr & style-src-elem csp directive if necessary [security]: automatically add nonce or hash to script-src-elem, style-src-attr & style-src-elem csp directive if necessary Jan 1, 2024
Comment thread .changeset/giant-years-drum.md Outdated
@Rich-Harris
Rich-Harris merged commit 1a1e786 into sveltejs:main Jan 8, 2024
@Rich-Harris

Copy link
Copy Markdown
Member

thank you!

@github-actions github-actions Bot mentioned this pull request Jan 8, 2024
Rich-Harris pushed a commit that referenced this pull request Jul 28, 2026
This block was born triplicated in #11562, which had to rewrite all
three sites #11485 touched two days earlier.

The report-only check parsed as `?.length ?? (0 > 0)` and only worked
because `0` and `undefined` are both falsy; the replacement has the same
truth table.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants