security: avoid CSP conflict with sha/nonce during dev & add support for 'style-src-elem' - #11562
Merged
Conversation
🦋 Changeset detectedLatest commit: 98271f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benmccann
reviewed
Jan 9, 2024
benmccann
reviewed
Jan 9, 2024
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Rich-Harris
approved these changes
Jan 9, 2024
Member
|
thank you! |
Merged
|
If |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a continuation from #11485, which solved sveltekit related problems to CSP.
after updating sveltekit i tried to remove
unsafe-inlinefromscript-src-elem,style-src-attr&style-src-elem. it worked onscript-src-elem, butstyle-src-attrandstyle-src-elemare not working. this is because of how svelte works with csp (sveltejs/svelte#7800).to combat some the
style-src-elemi've extended CSP so it automatically adds the SHA for the/* empty */value if not already added tostyle-src-elem.i'm not quite sure how
style-src-attrshould be fixed, i believe this has to be done via Svelte with CSSOM.extra: i've also made it so that CSP removes hashes and nonces from
style-src,style-src-attrorstyle-src-elemduring dev when adding the "unsafe-inline" to solve this error message:i noticed this after adding the hash myself on my app when trying to solve the
style-src-elembug.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits
Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.